LinuxLists.cc - [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

2017-03-22 18:05:23

Subject: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
It covers only the native build because it's computed from uname -m output.
For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
the test.
Fix the test to allow both native and cross-compilation of the test.

Note: glibc is missing several of the TRAP_* constants in the userspace
definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
See https://sourceware.org/bugzilla/show_bug.cgi?id=21286

Signed-off-by: Fathi Boudra <[email protected]>
---
tools/testing/selftests/breakpoints/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
index 72aa103e4141..6b214b7b10fb 100644
--- a/tools/testing/selftests/breakpoints/Makefile
+++ b/tools/testing/selftests/breakpoints/Makefile
@@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
ifeq ($(ARCH),x86)
TEST_GEN_PROGS := breakpoint_test
endif
-ifeq ($(ARCH),aarch64)
+ifneq (,$(filter $(ARCH),aarch64 arm64))
TEST_GEN_PROGS := breakpoint_test_arm64
endif

--
2.11.0

2017-03-30 12:23:37

by Naresh Kamboju

[permalink] [raw]

Subject: Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

Hi Fathi,

On 22 March 2017 at 23:34, Fathi Boudra <[email protected]> wrote:
> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
> It covers only the native build because it's computed from uname -m output.
> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
> the test.
> Fix the test to allow both native and cross-compilation of the test.
>
> Note: glibc is missing several of the TRAP_* constants in the userspace
> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>
> Signed-off-by: Fathi Boudra <[email protected]>
> ---
> tools/testing/selftests/breakpoints/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 72aa103e4141..6b214b7b10fb 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> ifeq ($(ARCH),x86)
> TEST_GEN_PROGS := breakpoint_test
> endif
> -ifeq ($(ARCH),aarch64)
> +ifneq (,$(filter $(ARCH),aarch64 arm64))
> TEST_GEN_PROGS := breakpoint_test_arm64
> endif

This patch works.
Tested on arm64 Hikey development board running 4.9 kernel.
Tested-by: Naresh Kamboju <[email protected]>

- Naresh

>
> --
> 2.11.0
>

2017-04-19 17:31:45

by Fathi Boudra

[permalink] [raw]

Subject: Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

gentle ping

On 22 March 2017 at 20:04, Fathi Boudra <[email protected]> wrote:
> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
> It covers only the native build because it's computed from uname -m output.
> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
> the test.
> Fix the test to allow both native and cross-compilation of the test.
>
> Note: glibc is missing several of the TRAP_* constants in the userspace
> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>
> Signed-off-by: Fathi Boudra <[email protected]>
> ---
> tools/testing/selftests/breakpoints/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 72aa103e4141..6b214b7b10fb 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> ifeq ($(ARCH),x86)
> TEST_GEN_PROGS := breakpoint_test
> endif
> -ifeq ($(ARCH),aarch64)
> +ifneq (,$(filter $(ARCH),aarch64 arm64))
> TEST_GEN_PROGS := breakpoint_test_arm64
> endif
>
> --
> 2.11.0
>

2017-04-19 20:22:11

by Shuah Khan

[permalink] [raw]

Subject: Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

On 04/19/2017 11:31 AM, Fathi Boudra wrote:
> gentle ping
>
> On 22 March 2017 at 20:04, Fathi Boudra <[email protected]> wrote:
>> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
>> It covers only the native build because it's computed from uname -m output.
>> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
>> the test.
>> Fix the test to allow both native and cross-compilation of the test.
>>
>> Note: glibc is missing several of the TRAP_* constants in the userspace
>> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
>> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>>
>> Signed-off-by: Fathi Boudra <[email protected]>

I plan to get to it towards the end of this week. Thanks for
the ping.

-- Shuah

>> ---
>> tools/testing/selftests/breakpoints/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
>> index 72aa103e4141..6b214b7b10fb 100644
>> --- a/tools/testing/selftests/breakpoints/Makefile
>> +++ b/tools/testing/selftests/breakpoints/Makefile
>> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>> ifeq ($(ARCH),x86)
>> TEST_GEN_PROGS := breakpoint_test
>> endif
>> -ifeq ($(ARCH),aarch64)
>> +ifneq (,$(filter $(ARCH),aarch64 arm64))
>> TEST_GEN_PROGS := breakpoint_test_arm64
>> endif
>>
>> --
>> 2.11.0
>>
>
>

2017-04-27 13:44:54

by Shuah Khan

[permalink] [raw]