2021-04-10 16:48:53

by Krzysztof Kozlowski

Subject: [PATCH] iio: adc: exynos: drop unneeded variable assignment

The initialization of 'ret' variable in probe function is shortly after
overwritten. This initialization is simply not used.

Addresses-Coverity: Unused value
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/iio/adc/exynos_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 784c10deeb1a..2d8e36408f0e 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = NULL;
bool has_ts = false;
- int ret = -ENODEV;
+ int ret;
int irq;

indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));
--
2.25.1

2021-04-11 13:57:19

by Alim Akhtar

Subject: Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment

On Sat, Apr 10, 2021 at 10:18 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> The initialization of 'ret' variable in probe function is shortly after
> overwritten. This initialization is simply not used.
>
> Addresses-Coverity: Unused value
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Thanks Krzysztof,
Reviewed-by: Alim Akhtar <[email protected]>

> drivers/iio/adc/exynos_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 784c10deeb1a..2d8e36408f0e 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> struct iio_dev *indio_dev = NULL;
> bool has_ts = false;
> - int ret = -ENODEV;
> + int ret;
> int irq;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));
> --
> 2.25.1
>


--
Regards,
Alim

2021-04-11 18:56:54

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment

On Sat, 10 Apr 2021 18:47:28 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> The initialization of 'ret' variable in probe function is shortly after
> overwritten. This initialization is simply not used.
>
> Addresses-Coverity: Unused value
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Too late for this cycle, but I've queued it up for the next one.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if we missed anything.

Thanks,

Jonathan

> ---
> drivers/iio/adc/exynos_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 784c10deeb1a..2d8e36408f0e 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev)
> struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev);
> struct iio_dev *indio_dev = NULL;
> bool has_ts = false;
> - int ret = -ENODEV;
> + int ret;
> int irq;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc));