2017-03-02 16:15:38

by Georgios Emmanouil

Subject: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

Modified the 'if-else' statement to make it more readable.

Signed-off-by: Georgios Emmanouil <[email protected]>
---
drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..d82f0ff 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -867,15 +867,10 @@ static int wilc_mac_open(struct net_device *ndev)
wilc_get_vif_idx(vif),
wl->open_ifcs);
} else {
- if (memcmp(wl->vif[i ^ 1]->bssid,
- wl->vif[i ^ 1]->src_addr, 6))
- wilc_set_wfi_drv_handler(vif,
- wilc_get_vif_idx(vif),
- 0);
+ if (memcmp(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 1]->src_addr, 6))
+ wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 0);
else
- wilc_set_wfi_drv_handler(vif,
- wilc_get_vif_idx(vif),
- 1);
+ wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 1);
}
wilc_set_operation_mode(vif, vif->iftype);

--
2.1.4

2017-03-04 22:48:20

by Julian Calaby

Subject: Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

Hi All,

On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil <[email protected]> wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil <[email protected]>

Again, I'm dubious if this is needed or helpful, but

Reviewed-by: Julian Calaby <[email protected]>

> ---
> drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/