2012-05-05 17:52:18

by Nick Dyer

Subject: Re: [PATCH 09/14 v3] Input: atmel_mxt_ts - refactor get info

Hi Daniel-

Daniel Kurtz wrote:
> - dev_info(&client->dev,
> - "Family ID: %d Variant ID: %d Version: %d Build: %d\n",
> - info->family_id, info->variant_id, info->version,
> - info->build);
> + dev_info(dev, "Family ID: %d Variant ID: %d Major.Minor.Build: %d.%d.%d\n",
> + info->family_id, info->variant_id, info->version >> 4,
> + info->version & 0xf, info->build);

The canonical format for the Atmel firmware versions has the build number
in hex, eg. 2.0.AA

So it should be %d.%d.%02X

cheers

Nick

2012-05-06 02:43:26

by Daniel Kurtz

Subject: Re: [PATCH 09/14 v3] Input: atmel_mxt_ts - refactor get info

On Sun, May 6, 2012 at 1:41 AM, Nick Dyer <[email protected]> wrote:
> Hi Daniel-
>
> Daniel Kurtz wrote:
>> - ? ? dev_info(&client->dev,
>> - ? ? ? ? ? ? ? ? ? ? "Family ID: %d Variant ID: %d Version: %d Build: %d\n",
>> - ? ? ? ? ? ? ? ? ? ? info->family_id, info->variant_id, info->version,
>> - ? ? ? ? ? ? ? ? ? ? info->build);
>> + ? ? dev_info(dev, "Family ID: %d Variant ID: %d Major.Minor.Build: %d.%d.%d\n",
>> + ? ? ? ? ? ? ?info->family_id, info->variant_id, info->version >> 4,
>> + ? ? ? ? ? ? ?info->version & 0xf, info->build);
>
> The canonical format for the Atmel firmware versions has the build number
> in hex, eg. 2.0.AA
>
> So it should be %d.%d.%02X

Nick,
Thanks! Will update. Or perhaps %u.%u.%02X ?
-Daniel

>
> cheers
>
> Nick