2019-12-14 18:12:31

by Frank Lee

Subject: [PATCH 2/2] PM / devfreq: rk3399_dmc: add missing of_node_put()

of_node_put() needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/devfreq/rk3399_dmc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 2e65d7279d79..2f1027c5b647 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -372,6 +372,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
node = of_parse_phandle(np, "rockchip,pmu", 0);
if (node) {
data->regmap_pmu = syscon_node_to_regmap(node);
+ of_node_put(node);
if (IS_ERR(data->regmap_pmu))
return PTR_ERR(data->regmap_pmu);
}
--
2.17.1

2019-12-15 15:33:31

by Chanwoo Choi

Subject: Re: [PATCH 2/2] PM / devfreq: rk3399_dmc: add missing of_node_put()

2019년 12월 15일 (일) 오전 3:12, Yangtao Li <[email protected]>님이 작성:
>
> of_node_put() needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/devfreq/rk3399_dmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 2e65d7279d79..2f1027c5b647 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -372,6 +372,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
> node = of_parse_phandle(np, "rockchip,pmu", 0);
> if (node) {
> data->regmap_pmu = syscon_node_to_regmap(node);
> + of_node_put(node);
> if (IS_ERR(data->regmap_pmu))
> return PTR_ERR(data->regmap_pmu);
> }
> --
> 2.17.1
>

Applied it.

--
Best Regards,
Chanwoo Choi