2018-10-23 11:19:12

by Denis Efremov (Oracle)

Subject: [PATCH] security: fix documentation for the path_chmod hook

From: Denis Efremov <[email protected]>

The path_chmod hook was changed in the commit
"switch security_path_chmod() to struct path *" (cdcf116d44e7).
The argument @mnt was removed from the hook, @dentry was changed
to @path. This patch updates the documentation accordingly.

Signed-off-by: Denis Efremov <[email protected]>
---
include/linux/lsm_hooks.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index a598e601ccb3..596351f7c3d1 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h
@@ -304,8 +304,7 @@
* Return 0 if permission is granted.
* @path_chmod:
* Check for permission to change DAC's permission of a file or directory.
- * @dentry contains the dentry structure.
- * @mnt contains the vfsmnt structure.
+ * @path contains the path structure.
* @mode contains DAC's mode.
* Return 0 if permission is granted.
* @path_chown:
--
2.17.2

2018-10-23 19:30:28

by Kees Cook

Subject: Re: [PATCH] security: fix documentation for the path_chmod hook

On Tue, Oct 23, 2018 at 4:16 AM, <[email protected]> wrote:
> From: Denis Efremov <[email protected]>
>
> The path_chmod hook was changed in the commit
> "switch security_path_chmod() to struct path *" (cdcf116d44e7).
> The argument @mnt was removed from the hook, @dentry was changed
> to @path. This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

-Kees

> ---
> include/linux/lsm_hooks.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index a598e601ccb3..596351f7c3d1 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -304,8 +304,7 @@
> * Return 0 if permission is granted.
> * @path_chmod:
> * Check for permission to change DAC's permission of a file or directory.
> - * @dentry contains the dentry structure.
> - * @mnt contains the vfsmnt structure.
> + * @path contains the path structure.
> * @mode contains DAC's mode.
> * Return 0 if permission is granted.
> * @path_chown:
> --
> 2.17.2
>



--
Kees Cook