2023-06-28 13:25:01

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH] media: dvb: mb86a20s: get rid of a clang-15 warning

When building with clang-15: this warning is produced:

../drivers/media/dvb-frontends/mb86a20s.c:1572:6: error: variable 'active_layers' set but not used [-Werror,-Wunused-but-set-variable]
int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
^
1 error generated.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
drivers/media/dvb-frontends/mb86a20s.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c
index b74b9afed9a2..125fed4891ba 100644
--- a/drivers/media/dvb-frontends/mb86a20s.c
+++ b/drivers/media/dvb-frontends/mb86a20s.c
@@ -1569,7 +1569,7 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
u32 t_post_bit_error = 0, t_post_bit_count = 0;
u32 block_error = 0, block_count = 0;
u32 t_block_error = 0, t_block_count = 0;
- int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
+ int pre_ber_layers = 0, post_ber_layers = 0;
int per_layers = 0;

dev_dbg(&state->i2c->dev, "%s called.\n", __func__);
@@ -1589,9 +1589,6 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)

for (layer = 0; layer < NUM_LAYERS; layer++) {
if (c->isdbt_layer_enabled & (1 << layer)) {
- /* Layer is active and has rc segments */
- active_layers++;
-
/* Handle BER before vterbi */
rc = mb86a20s_get_pre_ber(fe, layer,
&bit_error, &bit_count);
--
2.41.0



2023-06-28 15:47:35

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH] media: dvb: mb86a20s: get rid of a clang-15 warning

On Wed, Jun 28, 2023 at 3:03 PM Mauro Carvalho Chehab
<[email protected]> wrote:
>
> When building with clang-15: this warning is produced:
>
> ../drivers/media/dvb-frontends/mb86a20s.c:1572:6: error: variable 'active_layers' set but not used [-Werror,-Wunused-but-set-variable]
> int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
> ^
> 1 error generated.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Chen-Yu Tsai <[email protected]>