2023-04-22 10:45:39

by Pin-yen Lin

Subject: [PATCH] media: mediatek: vcodec: Only apply 4K frame sizes on decoder formats

When VCODEC_CAPABILITY_4K_DISABLED is not set in dec_capability, skip
formats that are not MTK_FMT_DEC so only decoder formats is updated in
mtk_init_vdec_params.

Fixes: e25528e1dbe5 ("media: mediatek: vcodec: Use 4K frame size when supported by stateful decoder")
Signed-off-by: Pin-yen Lin <[email protected]>
---

.../media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
index 29991551cf61..0fbd030026c7 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
@@ -584,6 +584,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx)

if (!(ctx->dev->dec_capability & VCODEC_CAPABILITY_4K_DISABLED)) {
for (i = 0; i < num_supported_formats; i++) {
+ if (mtk_video_formats[i].type != MTK_FMT_DEC)
+ continue;
+
mtk_video_formats[i].frmsize.max_width =
VCODEC_DEC_4K_CODED_WIDTH;
mtk_video_formats[i].frmsize.max_height =
--
2.40.0.634.g4ca3ef3211-goog

2023-04-25 06:50:33

by Chen-Yu Tsai

Subject: Re: [PATCH] media: mediatek: vcodec: Only apply 4K frame sizes on decoder formats

On Sat, Apr 22, 2023 at 6:39 PM Pin-yen Lin <[email protected]> wrote:
>
> When VCODEC_CAPABILITY_4K_DISABLED is not set in dec_capability, skip
> formats that are not MTK_FMT_DEC so only decoder formats is updated in
> mtk_init_vdec_params.
>
> Fixes: e25528e1dbe5 ("media: mediatek: vcodec: Use 4K frame size when supported by stateful decoder")
> Signed-off-by: Pin-yen Lin <[email protected]>

Reviewed-by: Chen-Yu Tsai <[email protected]>

> ---
>
> .../media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> index 29991551cf61..0fbd030026c7 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> @@ -584,6 +584,9 @@ static void mtk_init_vdec_params(struct mtk_vcodec_ctx *ctx)
>
> if (!(ctx->dev->dec_capability & VCODEC_CAPABILITY_4K_DISABLED)) {
> for (i = 0; i < num_supported_formats; i++) {
> + if (mtk_video_formats[i].type != MTK_FMT_DEC)
> + continue;
> +
> mtk_video_formats[i].frmsize.max_width =
> VCODEC_DEC_4K_CODED_WIDTH;
> mtk_video_formats[i].frmsize.max_height =
> --
> 2.40.0.634.g4ca3ef3211-goog
>

2023-04-25 11:34:52

by Yunfei Dong (董云飞)

Subject: Re: [PATCH] media: mediatek: vcodec: Only apply 4K frame sizes on decoder formats

On Sat, 2023-04-22 at 18:39 +0800, Pin-yen Lin wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> When VCODEC_CAPABILITY_4K_DISABLED is not set in dec_capability, skip
> formats that are not MTK_FMT_DEC so only decoder formats is updated
> in
> mtk_init_vdec_params.
>
> Fixes: e25528e1dbe5 ("media: mediatek: vcodec: Use 4K frame size when
> supported by stateful decoder")
> Signed-off-by: Pin-yen Lin <[email protected]>
> ---
>
Reviewed-by: Yunfei Dong <[email protected]>
> .../media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c | 3
> +++
> 1 file changed, 3 insertions(+)
>
> diff --git
> a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> index 29991551cf61..0fbd030026c7 100644
> ---
> a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> +++
> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_stateful.c
> @@ -584,6 +584,9 @@ static void mtk_init_vdec_params(struct
> mtk_vcodec_ctx *ctx)
>
> if (!(ctx->dev->dec_capability &
> VCODEC_CAPABILITY_4K_DISABLED)) {
> for (i = 0; i < num_supported_formats; i++) {
> + if (mtk_video_formats[i].type != MTK_FMT_DEC)
> + continue;
> +
> mtk_video_formats[i].frmsize.max_width =
> VCODEC_DEC_4K_CODED_WIDTH;
> mtk_video_formats[i].frmsize.max_height =
> --
> 2.40.0.634.g4ca3ef3211-goog
>