On Tue, 30 Sep 2014, Benjamin Tissoires wrote:
> Jiri, This patch series can be split in 2 if you would like:
> - patches 1 to 4 can be scheduled easily for 3.18 IMO
> - patches 5 to 13 might need some more reviews, so either 3.18 or 3.19
Benjamin,
thanks for the summary. I'll try to review 1-4 in time for 3.18, but I
can't guarantee that.
Do you forsee any issues if the whole lot is queued for 3.19 only?
--
Jiri Kosina
SUSE Labs
On Oct 01 2014 or thereabouts, Jiri Kosina wrote:
> On Tue, 30 Sep 2014, Benjamin Tissoires wrote:
>
> > Jiri, This patch series can be split in 2 if you would like:
> > - patches 1 to 4 can be scheduled easily for 3.18 IMO
> > - patches 5 to 13 might need some more reviews, so either 3.18 or 3.19
>
> Benjamin,
>
> thanks for the summary. I'll try to review 1-4 in time for 3.18, but I
> can't guarantee that.
>
Thanks
> Do you forsee any issues if the whole lot is queued for 3.19 only?
Nope. It waited since 2011, so it can wait 3 more months :)
Cheers,
Benjamin
I've tested these patches successfully on a Chromebook Pixel with the
following devices:
- T650 touchpad
- TK820 keyboard/touchpad
- Original WTP touchpad
I also tested a touch mouse and as expected it continued to function
as a plain USB mouse. The TK820 was indeed broken into two devices,
with autorepeat enabled for the keyboard only. The other two devices
behaved as expected with no perceived regressions.
In short, from a functionality perspective I'm happy with these
patches. I will let others discuss code structure.
-andrew
On Wed, Oct 1, 2014 at 6:10 AM, Benjamin Tissoires
<[email protected]> wrote:
> On Oct 01 2014 or thereabouts, Jiri Kosina wrote:
>> On Tue, 30 Sep 2014, Benjamin Tissoires wrote:
>>
>> > Jiri, This patch series can be split in 2 if you would like:
>> > - patches 1 to 4 can be scheduled easily for 3.18 IMO
>> > - patches 5 to 13 might need some more reviews, so either 3.18 or 3.19
>>
>> Benjamin,
>>
>> thanks for the summary. I'll try to review 1-4 in time for 3.18, but I
>> can't guarantee that.
>>
>
> Thanks
>
>> Do you forsee any issues if the whole lot is queued for 3.19 only?
>
> Nope. It waited since 2011, so it can wait 3 more months :)
>
> Cheers,
> Benjamin
>
On Thu, 2 Oct 2014, Andrew de los Reyes wrote:
> I've tested these patches successfully on a Chromebook Pixel with the
> following devices:
>
> - T650 touchpad
> - TK820 keyboard/touchpad
> - Original WTP touchpad
>
> I also tested a touch mouse and as expected it continued to function
> as a plain USB mouse. The TK820 was indeed broken into two devices,
> with autorepeat enabled for the keyboard only. The other two devices
> behaved as expected with no perceived regressions.
>
> In short, from a functionality perspective I'm happy with these
> patches. I will let others discuss code structure.
Thank you. Can I use
Tested-by: Andrew de los Reyes <[email protected]>
once / if I am merging this patchset?
--
Jiri Kosina
SUSE Labs
Sure, but I would prefer to use my chromium account:
Tested-by: Andrew de los Reyes <[email protected]>
On Fri, Oct 3, 2014 at 4:09 AM, Jiri Kosina <[email protected]> wrote:
> On Thu, 2 Oct 2014, Andrew de los Reyes wrote:
>
>> I've tested these patches successfully on a Chromebook Pixel with the
>> following devices:
>>
>> - T650 touchpad
>> - TK820 keyboard/touchpad
>> - Original WTP touchpad
>>
>> I also tested a touch mouse and as expected it continued to function
>> as a plain USB mouse. The TK820 was indeed broken into two devices,
>> with autorepeat enabled for the keyboard only. The other two devices
>> behaved as expected with no perceived regressions.
>>
>> In short, from a functionality perspective I'm happy with these
>> patches. I will let others discuss code structure.
>
> Thank you. Can I use
>
> Tested-by: Andrew de los Reyes <[email protected]>
>
> once / if I am merging this patchset?
>
> --
> Jiri Kosina
> SUSE Labs
On Fri, Oct 3, 2014 at 7:09 AM, Jiri Kosina <[email protected]> wrote:
> On Thu, 2 Oct 2014, Andrew de los Reyes wrote:
>
>> I've tested these patches successfully on a Chromebook Pixel with the
>> following devices:
>>
>> - T650 touchpad
>> - TK820 keyboard/touchpad
>> - Original WTP touchpad
>>
>> I also tested a touch mouse and as expected it continued to function
>> as a plain USB mouse. The TK820 was indeed broken into two devices,
>> with autorepeat enabled for the keyboard only. The other two devices
>> behaved as expected with no perceived regressions.
>>
>> In short, from a functionality perspective I'm happy with these
>> patches. I will let others discuss code structure.
>
> Thank you. Can I use
>
> Tested-by: Andrew de los Reyes <[email protected]>
>
> once / if I am merging this patchset?
>
I am pretty sure this is not required too, but I am raising this one
again in Jiri's pile of things to review.
Sorry Jiri, I did not forget about it :)
Cheers,
Benjamin
On Tue, 28 Oct 2014, Benjamin Tissoires wrote:
> >> I've tested these patches successfully on a Chromebook Pixel with the
> >> following devices:
> >>
> >> - T650 touchpad
> >> - TK820 keyboard/touchpad
> >> - Original WTP touchpad
> >>
> >> I also tested a touch mouse and as expected it continued to function
> >> as a plain USB mouse. The TK820 was indeed broken into two devices,
> >> with autorepeat enabled for the keyboard only. The other two devices
> >> behaved as expected with no perceived regressions.
> >>
> >> In short, from a functionality perspective I'm happy with these
> >> patches. I will let others discuss code structure.
> >
> > Thank you. Can I use
> >
> > Tested-by: Andrew de los Reyes <[email protected]>
> >
> > once / if I am merging this patchset?
> >
>
> I am pretty sure this is not required too, but I am raising this one
> again in Jiri's pile of things to review.
> Sorry Jiri, I did not forget about it :)
It absolutely hasn't been forgotten, I've been just a bit busy during past
weeks.
I am almost done with the review, expect to hear from me in a 1-2 days
timeframe regarding this series.
Thanks for patience,
--
Jiri Kosina
SUSE Labs
On Wed, Oct 29, 2014 at 5:49 AM, Jiri Kosina <[email protected]> wrote:
> On Tue, 28 Oct 2014, Benjamin Tissoires wrote:
>
>> >> I've tested these patches successfully on a Chromebook Pixel with the
>> >> following devices:
>> >>
>> >> - T650 touchpad
>> >> - TK820 keyboard/touchpad
>> >> - Original WTP touchpad
>> >>
>> >> I also tested a touch mouse and as expected it continued to function
>> >> as a plain USB mouse. The TK820 was indeed broken into two devices,
>> >> with autorepeat enabled for the keyboard only. The other two devices
>> >> behaved as expected with no perceived regressions.
>> >>
>> >> In short, from a functionality perspective I'm happy with these
>> >> patches. I will let others discuss code structure.
>> >
>> > Thank you. Can I use
>> >
>> > Tested-by: Andrew de los Reyes <[email protected]>
>> >
>> > once / if I am merging this patchset?
>> >
>>
>> I am pretty sure this is not required too, but I am raising this one
>> again in Jiri's pile of things to review.
>> Sorry Jiri, I did not forget about it :)
>
> It absolutely hasn't been forgotten, I've been just a bit busy during past
> weeks.
No worries. I definitively understand. Being close to the merge window
is never a good time to send you patches and I am sure SuSE asks you a
lot also :)
>
> I am almost done with the review, expect to hear from me in a 1-2 days
> timeframe regarding this series.
Cool, thanks. That is much appreciated.
Cheers,
Benjamin
On Wed, 29 Oct 2014, Benjamin Tissoires wrote:
> No worries. I definitively understand. Being close to the merge window
> is never a good time to send you patches and I am sure SuSE asks you a
> lot also :)
Indeed, sometimes the flow of inbound things is just unstoppable :)
> > I am almost done with the review, expect to hear from me in a 1-2 days
> > timeframe regarding this series.
>
> Cool, thanks. That is much appreciated.
I have now applied the whole patchset and pushed out.
Thanks,
--
Jiri Kosina
SUSE Labs
On Wed, Oct 29, 2014 at 12:14 PM, Jiri Kosina <[email protected]> wrote:
> On Wed, 29 Oct 2014, Benjamin Tissoires wrote:
>
>> No worries. I definitively understand. Being close to the merge window
>> is never a good time to send you patches and I am sure SuSE asks you a
>> lot also :)
>
> Indeed, sometimes the flow of inbound things is just unstoppable :)
>
>> > I am almost done with the review, expect to hear from me in a 1-2 days
>> > timeframe regarding this series.
>>
>> Cool, thanks. That is much appreciated.
>
> I have now applied the whole patchset and pushed out.
>
That was much faster than expected!!! Thanks a lot.
Cheers,
Benjamin