2022-04-28 21:12:46

by Alexander Potapenko

Subject: Re: [PATCH 1/3] kasan: clean up comments in internal kasan.h

On Thu, Apr 28, 2022 at 6:21 PM <[email protected]> wrote:
>
> From: Andrey Konovalov <[email protected]>
>
> Clean up comments in mm/kasan/kasan.h: clarify, unify styles, fix
> punctuation, etc.
>
> Signed-off-by: Andrey Konovalov <[email protected]>

Reviewed-by: Alexander Potapenko <[email protected]>

>
> +/* alloca redzone size. Compiler's ABI, do not change. */
s/Compiler's/Compiler ?

> #define KASAN_ALLOCA_REDZONE_SIZE 32
>
> -/*
> - * Stack frame marker (compiler ABI).
> - */
> +/* Stack frame marker. Compiler's ABI, do not change. */
Ditto

>
> -/* The layout of struct dictated by compiler */
> +/* Do not change the struct layout: compiler's ABI. */
Ditto

> -/* The layout of struct dictated by compiler */
> +/* Do not change the struct layout: compiler's ABI. */
Ditto

> - unsigned long has_dynamic_init; /* This needed for C++ */
> + unsigned long has_dynamic_init; /* This needed for C++. */
"is needed"?


> - * is accepted since SLAB redzones aren't enabled in production builds.
> + * is accepted since slab redzones aren't enabled in production builds.
s/accepted/acceptable ?

2022-05-09 15:52:23

by Andrey Konovalov

Subject: Re: [PATCH 1/3] kasan: clean up comments in internal kasan.h

On Thu, Apr 28, 2022 at 6:42 PM Alexander Potapenko <[email protected]> wrote:
>
> On Thu, Apr 28, 2022 at 6:21 PM <[email protected]> wrote:
> >
> > From: Andrey Konovalov <[email protected]>
> >
> > Clean up comments in mm/kasan/kasan.h: clarify, unify styles, fix
> > punctuation, etc.
> >
> > Signed-off-by: Andrey Konovalov <[email protected]>
>
> Reviewed-by: Alexander Potapenko <[email protected]>
>
> >
> > +/* alloca redzone size. Compiler's ABI, do not change. */
> s/Compiler's/Compiler ?
>
> > #define KASAN_ALLOCA_REDZONE_SIZE 32
> >
> > -/*
> > - * Stack frame marker (compiler ABI).
> > - */
> > +/* Stack frame marker. Compiler's ABI, do not change. */
> Ditto
>
> >
> > -/* The layout of struct dictated by compiler */
> > +/* Do not change the struct layout: compiler's ABI. */
> Ditto
>
> > -/* The layout of struct dictated by compiler */
> > +/* Do not change the struct layout: compiler's ABI. */
> Ditto
>
> > - unsigned long has_dynamic_init; /* This needed for C++ */
> > + unsigned long has_dynamic_init; /* This needed for C++. */
> "is needed"?
>
>
> > - * is accepted since SLAB redzones aren't enabled in production builds.
> > + * is accepted since slab redzones aren't enabled in production builds.
> s/accepted/acceptable ?

Will fix all in v2, thanks!