2023-03-25 11:45:46

by Krzysztof Kozlowski

Subject: [PATCH] dt-bindings: mfd: x-powers,axp152: simplify disallowing properties

The syntax to disallow x-powers,drive-vbus-en,
x-powers,self-working-mode and x-powers,master-mode for certain variants
can be made simpler. Also this produces much nicer warning message when
the condition hits wrong DTS.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Cc: Andre Przywara <[email protected]>
---
.../devicetree/bindings/mfd/x-powers,axp152.yaml | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
index 24d03996b93a..8eeb5b387430 100644
--- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
+++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
@@ -47,9 +47,8 @@ allOf:
- x-powers,axp209

then:
- not:
- required:
- - x-powers,drive-vbus-en
+ properties:
+ x-powers,drive-vbus-en: false

- if:
not:
@@ -59,14 +58,9 @@ allOf:
const: x-powers,axp806

then:
- allOf:
- - not:
- required:
- - x-powers,self-working-mode
-
- - not:
- required:
- - x-powers,master-mode
+ properties:
+ x-powers,self-working-mode: false
+ x-powers,master-mode: false

- if:
not:
--
2.34.1

2023-03-28 14:07:16

by Andre Przywara

Subject: Re: [PATCH] dt-bindings: mfd: x-powers,axp152: simplify disallowing properties

On Sat, 25 Mar 2023 12:43:53 +0100
Krzysztof Kozlowski <[email protected]> wrote:

Hi,

> The syntax to disallow x-powers,drive-vbus-en,
> x-powers,self-working-mode and x-powers,master-mode for certain variants
> can be made simpler. Also this produces much nicer warning message when
> the condition hits wrong DTS.

Ah, indeed, that reads much nicer!

> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Andre Przywara <[email protected]>
Tested-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
>
> Cc: Andre Przywara <[email protected]>
> ---
> .../devicetree/bindings/mfd/x-powers,axp152.yaml | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> index 24d03996b93a..8eeb5b387430 100644
> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
> @@ -47,9 +47,8 @@ allOf:
> - x-powers,axp209
>
> then:
> - not:
> - required:
> - - x-powers,drive-vbus-en
> + properties:
> + x-powers,drive-vbus-en: false
>
> - if:
> not:
> @@ -59,14 +58,9 @@ allOf:
> const: x-powers,axp806
>
> then:
> - allOf:
> - - not:
> - required:
> - - x-powers,self-working-mode
> -
> - - not:
> - required:
> - - x-powers,master-mode
> + properties:
> + x-powers,self-working-mode: false
> + x-powers,master-mode: false
>
> - if:
> not:

2023-03-28 14:18:04

by Chen-Yu Tsai

Subject: Re: [PATCH] dt-bindings: mfd: x-powers,axp152: simplify disallowing properties

On Tue, Mar 28, 2023 at 10:03 PM Andre Przywara <[email protected]> wrote:
>
> On Sat, 25 Mar 2023 12:43:53 +0100
> Krzysztof Kozlowski <[email protected]> wrote:
>
> Hi,
>
> > The syntax to disallow x-powers,drive-vbus-en,
> > x-powers,self-working-mode and x-powers,master-mode for certain variants
> > can be made simpler. Also this produces much nicer warning message when
> > the condition hits wrong DTS.
>
> Ah, indeed, that reads much nicer!
>
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Reviewed-by: Andre Przywara <[email protected]>
> Tested-by: Andre Przywara <[email protected]>

Acked-by: Chen-Yu Tsai <[email protected]>

2023-03-30 13:38:12

by Lee Jones

Subject: Re: [PATCH] dt-bindings: mfd: x-powers,axp152: simplify disallowing properties

On Sat, 25 Mar 2023, Krzysztof Kozlowski wrote:

> The syntax to disallow x-powers,drive-vbus-en,
> x-powers,self-working-mode and x-powers,master-mode for certain variants
> can be made simpler. Also this produces much nicer warning message when
> the condition hits wrong DTS.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied, thanks

--
Lee Jones [李琼斯]