2021-10-19 08:06:50

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 00/23] Fix some issues at documentation

Hi Jon,

This series is against today's next (next-20211019) and addresses missing
links to Documentation/*.

The best would be to have the patches applied directly to the trees that
contain the patches that moved/renamed files, and then apply the
remaining ones either later during the merge window or just afterwards,
whatever works best for you.

Regards,
Mauro

Mauro Carvalho Chehab (23):
visorbus: fix a copyright symbol that was bad encoded
libbpf: update index.rst reference
docs: accounting: update delay-accounting.rst reference
MAINTAINERS: update arm,vic.yaml reference
MAINTAINERS: update aspeed,i2c.yaml reference
MAINTAINERS: update faraday,ftrtc010.yaml reference
MAINTAINERS: update ti,sci.yaml reference
MAINTAINERS: update intel,ixp46x-rng.yaml reference
MAINTAINERS: update nxp,imx8-jpeg.yaml reference
MAINTAINERS: update gemini.yaml reference
MAINTAINERS: update brcm,unimac-mdio.yaml reference
MAINTAINERS: update mtd-physmap.yaml reference
Documentation: update vcpu-requests.rst reference
bpftool: update bpftool-cgroup.rst reference
docs: translations: zn_CN: irq-affinity.rst: add a missing extension
docs: translations: zh_CN: memory-hotplug.rst: fix a typo
docs: fs: locks.rst: update comment about mandatory file locking
fs: remove a comment pointing to the removed mandatory-locking file
Documentation/process: fix a cross reference
dt-bindings: mfd: update x-powers,axp152.yaml reference
regulator: dt-bindings: update samsung,s2mpa01.yaml reference
regulator: dt-bindings: update samsung,s5m8767.yaml reference
dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

Documentation/admin-guide/ramoops.rst | 2 +-
Documentation/admin-guide/sysctl/kernel.rst | 2 +-
Documentation/bpf/index.rst | 2 +-
.../devicetree/bindings/gpio/gpio-axp209.txt | 2 +-
.../bindings/regulator/samsung,s2mpa01.yaml | 2 +-
.../bindings/regulator/samsung,s5m8767.yaml | 2 +-
Documentation/filesystems/locks.rst | 17 +++++-----------
Documentation/process/submitting-patches.rst | 4 ++--
.../zh_CN/core-api/irq/irq-affinity.rst | 2 +-
.../zh_CN/core-api/memory-hotplug.rst | 2 +-
MAINTAINERS | 20 +++++++++----------
arch/riscv/kvm/vcpu.c | 2 +-
drivers/visorbus/visorbus_main.c | 2 +-
fs/locks.c | 1 -
.../selftests/bpf/test_bpftool_synctypes.py | 2 +-
15 files changed, 28 insertions(+), 36 deletions(-)

--
2.31.1



2021-10-19 08:06:53

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 09/23] MAINTAINERS: update nxp,imx8-jpeg.yaml reference

The file name: Documentation/devicetree/bindings/media/imx8-jpeg.yaml
should be, instead: Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml.

Update its cross-reference accordingly.

Fixes: be157db0a3d8 ("media: Add maintainer for IMX jpeg v4l2 driver")
Fixes: b16ed1e66008 ("media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver")
Reviewed-by: Mirela Rabulea <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 843cb9779f4f..33147a1495f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13702,7 +13702,7 @@ M: Mirela Rabulea <[email protected]>
R: NXP Linux Team <[email protected]>
L: [email protected]
S: Maintained
-F: Documentation/devicetree/bindings/media/imx8-jpeg.yaml
+F: Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
F: drivers/media/platform/imx-jpeg

NZXT-KRAKEN2 HARDWARE MONITORING DRIVER
--
2.31.1

2021-10-19 08:06:58

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 17/23] docs: fs: locks.rst: update comment about mandatory file locking

The mandatory file locking got removed due to its problems, but
the fs locks documentation still points to it.

Update the text there, informing that it was removed on Kernel
5.14.

Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

Documentation/filesystems/locks.rst | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/Documentation/filesystems/locks.rst b/Documentation/filesystems/locks.rst
index c5ae858b1aac..26429317dbbc 100644
--- a/Documentation/filesystems/locks.rst
+++ b/Documentation/filesystems/locks.rst
@@ -57,16 +57,9 @@ fcntl(), with all the problems that implies.
1.3 Mandatory Locking As A Mount Option
---------------------------------------

-Mandatory locking, as described in
-'Documentation/filesystems/mandatory-locking.rst' was prior to this release a
-general configuration option that was valid for all mounted filesystems. This
-had a number of inherent dangers, not the least of which was the ability to
-freeze an NFS server by asking it to read a file for which a mandatory lock
-existed.
-
-From this release of the kernel, mandatory locking can be turned on and off
-on a per-filesystem basis, using the mount options 'mand' and 'nomand'.
-The default is to disallow mandatory locking. The intention is that
-mandatory locking only be enabled on a local filesystem as the specific need
-arises.
+Mandatory locking was prior to this release a general configuration option
+that was valid for all mounted filesystems. This had a number of inherent
+dangers, not the least of which was the ability to freeze an NFS server by
+asking it to read a file for which a mandatory lock existed.

+Such option was dropped in Kernel v5.14.
--
2.31.1

2021-10-19 08:07:08

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

memory_hotplug.rst -> memory-hotplug.rst

Fixes: 620127548a69 ("docs/zh_CN: add core api memory_hotplug translation")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

Documentation/translations/zh_CN/core-api/memory-hotplug.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
index 9a204eb196f2..9b2841fb9a5f 100644
--- a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
+++ b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
@@ -1,6 +1,6 @@
.. include:: ../disclaimer-zh_CN.rst

-:Original: Documentation/core-api/memory_hotplug.rst
+:Original: Documentation/core-api/memory-hotplug.rst

:翻译:

--
2.31.1

2021-10-19 08:07:18

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference

Changeset f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
renamed: Documentation/devicetree/bindings/mfd/axp20x.txt
to: Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml.

Update its cross-reference accordingly.

Fixes: f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
index fc42b2caa06d..538f04e60ff9 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
@@ -17,7 +17,7 @@ Required properties:
- gpio-controller: Marks the device node as a GPIO controller.

This node must be a subnode of the axp20x PMIC, documented in
-Documentation/devicetree/bindings/mfd/axp20x.txt
+Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml

Example:

--
2.31.1

2021-10-19 08:07:38

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

The file name: Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml
should be, instead: Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml.

Update its cross-reference accordingly.

Fixes: a52afb0f54fa ("regulator: dt-bindings: samsung,s2mpa01: convert to dtschema")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

.../devicetree/bindings/regulator/samsung,s2mpa01.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
index 0627dec513da..0a564319f4b2 100644
--- a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
+++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
@@ -15,7 +15,7 @@ description: |

The S2MPA01 provides buck and LDO regulators.

- See also Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml for
+ See also Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml for
additional information and example.

patternProperties:
--
2.31.1

2021-10-19 08:07:50

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 03/23] docs: accounting: update delay-accounting.rst reference

The file name: accounting/delay-accounting.rst
should be, instead: Documentation/accounting/delay-accounting.rst.

Also, there's no need to use doc:`foo`, as automarkup.py will
automatically handle plain text mentions to Documentation/
files.

So, update its cross-reference accordingly.

Fixes: fcb501704554 ("delayacct: Document task_delayacct sysctl")
Fixes: c3123552aad3 ("docs: accounting: convert to ReST")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

Documentation/admin-guide/sysctl/kernel.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
index 426162009ce9..0e486f41185e 100644
--- a/Documentation/admin-guide/sysctl/kernel.rst
+++ b/Documentation/admin-guide/sysctl/kernel.rst
@@ -1099,7 +1099,7 @@ task_delayacct
===============

Enables/disables task delay accounting (see
-:doc:`accounting/delay-accounting.rst`). Enabling this feature incurs
+Documentation/accounting/delay-accounting.rst. Enabling this feature incurs
a small amount of overhead in the scheduler but is useful for debugging
and performance tuning. It is required by some tools such as iotop.

--
2.31.1

2021-10-19 08:08:02

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

The file name: Documentation/bpftool-cgroup.rst
should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.

Update its cross-reference accordingly.

Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
index be54b7335a76..617b8084c440 100755
--- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
+++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
@@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
"""
An extractor for bpftool-cgroup.rst.
"""
- filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
+ filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')

def get_attach_types(self):
return self.get_rst_list('ATTACH_TYPE')
--
2.31.1

2021-10-19 08:08:03

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 01/23] visorbus: fix a copyright symbol that was bad encoded

The copyright symbol was badly encoded using the
REPLACEMENT CHARACTER U+fffd ('�'), probably due to some
bad charset conversion.

Fix it.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

drivers/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/visorbus/visorbus_main.c b/drivers/visorbus/visorbus_main.c
index 152fd29f04f2..0aa4cff670dc 100644
--- a/drivers/visorbus/visorbus_main.c
+++ b/drivers/visorbus/visorbus_main.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Copyright � 2010 - 2015 UNISYS CORPORATION
+ * Copyright © 2010 - 2015 UNISYS CORPORATION
* All rights reserved.
*/

--
2.31.1

2021-10-19 08:08:03

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference

Changeset b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
renamed: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
to: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml.

Update its cross-reference accordingly.

Fixes: b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
Reviewed-by: Linus Walleij <[email protected]>
Acked-by: Sudeep Holla <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a10b915292e1..22efd0c518a1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1560,7 +1560,7 @@ ARM PRIMECELL VIC PL190/PL192 DRIVER
M: Linus Walleij <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Maintained
-F: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
+F: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml
F: drivers/irqchip/irq-vic.c

ARM SMC WATCHDOG DRIVER
--
2.31.1

2021-10-19 08:08:05

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 07/23] MAINTAINERS: update ti,sci.yaml reference

Changeset 5a9652f6994e ("dt-bindings: arm: keystone: Convert ti,sci to json schema")
renamed: Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
to: Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml.

Update its cross-reference accordingly.

Fixes: 5a9652f6994e ("dt-bindings: arm: keystone: Convert ti,sci to json schema")
Reviewed-by: Nishanth Menon <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d1721a65d79b..5459f6ec8c10 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18744,7 +18744,7 @@ M: Santosh Shilimkar <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Maintained
F: Documentation/devicetree/bindings/arm/keystone/ti,k3-sci-common.yaml
-F: Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
+F: Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
F: Documentation/devicetree/bindings/clock/ti,sci-clk.yaml
F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml
--
2.31.1

2021-10-19 08:08:11

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 22/23] regulator: dt-bindings: update samsung,s5m8767.yaml reference

The file name: Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
should be, instead: Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml.

Update its cross-reference accordingly.

Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

.../devicetree/bindings/regulator/samsung,s5m8767.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
index 80a63d47790a..4281f670c775 100644
--- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
+++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
@@ -15,7 +15,7 @@ description: |

The S5M8767 provides buck and LDO regulators.

- See also Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml for
+ See also Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml for
additional information and example.

patternProperties:
--
2.31.1

2021-10-19 08:08:23

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v3 06/23] MAINTAINERS: update faraday,ftrtc010.yaml reference

Changeset 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
renamed: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
to: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml.

Update its cross-reference accordingly.

Fixes: 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fb898af23d0a..d1721a65d79b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1888,7 +1888,7 @@ T: git git://github.com/ulli-kroll/linux.git
F: Documentation/devicetree/bindings/arm/gemini.txt
F: Documentation/devicetree/bindings/net/cortina,gemini-ethernet.txt
F: Documentation/devicetree/bindings/pinctrl/cortina,gemini-pinctrl.txt
-F: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
+F: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
F: arch/arm/boot/dts/gemini*
F: arch/arm/mach-gemini/
F: drivers/crypto/gemini/
--
2.31.1

2021-10-19 08:27:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

On 19/10/2021 10:04, Mauro Carvalho Chehab wrote:
> The file name: Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml
> should be, instead: Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: a52afb0f54fa ("regulator: dt-bindings: samsung,s2mpa01: convert to dtschema")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> .../devicetree/bindings/regulator/samsung,s2mpa01.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
> index 0627dec513da..0a564319f4b2 100644
> --- a/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml
> @@ -15,7 +15,7 @@ description: |
>
> The S2MPA01 provides buck and LDO regulators.
>
> - See also Documentation/devicetree/bindings/mfd/samsung,s2mpa01.yaml for
> + See also Documentation/devicetree/bindings/regulator/samsung,s2mpa01.yaml for
> additional information and example.
>

Hi Mauro,

Thanks for the patch but it is incorrect. Old path is proper, just the
patch waits on merging.

For this one: NAK.

Best regards,
Krzysztof

2021-10-19 08:28:14

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 22/23] regulator: dt-bindings: update samsung,s5m8767.yaml reference

On 19/10/2021 10:04, Mauro Carvalho Chehab wrote:
> The file name: Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
> should be, instead: Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> .../devicetree/bindings/regulator/samsung,s5m8767.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> index 80a63d47790a..4281f670c775 100644
> --- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
> @@ -15,7 +15,7 @@ description: |
>
> The S5M8767 provides buck and LDO regulators.
>
> - See also Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml for
> + See also Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml for
> additional information and example.
>
> patternProperties:
>


Hi Mauro,

Thanks for the patch but it is incorrect. Old path is proper, just the
patch waits on merging.

For this one: NAK.

Best regards,
Krzysztof

2021-10-19 09:38:02

by Quentin Monnet

[permalink] [raw]
Subject: Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
<[email protected]>
> The file name: Documentation/bpftool-cgroup.rst
> should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.
>
> Update its cross-reference accordingly.
>
> Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
> Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> index be54b7335a76..617b8084c440 100755
> --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> @@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
> """
> An extractor for bpftool-cgroup.rst.
> """
> - filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
> + filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
>
> def get_attach_types(self):
> return self.get_rst_list('ATTACH_TYPE')
>

No, this change is incorrect. We have discussed it several times before
[0][1]. Please drop this patch.

Quentin

[0]
https://lore.kernel.org/bpf/[email protected]/
[1]
https://lore.kernel.org/bpf/CAEf4BzZhr+3JzuPvyTozQSts7QixnyY1N8CD+-ZuteHodCpmRA@mail.gmail.com/

2021-10-19 10:49:00

by Jeffrey Layton

[permalink] [raw]
Subject: Re: [PATCH v3 17/23] docs: fs: locks.rst: update comment about mandatory file locking

On Tue, 2021-10-19 at 09:04 +0100, Mauro Carvalho Chehab wrote:
> The mandatory file locking got removed due to its problems, but
> the fs locks documentation still points to it.
>
> Update the text there, informing that it was removed on Kernel
> 5.14.
>
> Fixes: f7e33bdbd6d1 ("fs: remove mandatory file locking support")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> Documentation/filesystems/locks.rst | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/filesystems/locks.rst b/Documentation/filesystems/locks.rst
> index c5ae858b1aac..26429317dbbc 100644
> --- a/Documentation/filesystems/locks.rst
> +++ b/Documentation/filesystems/locks.rst
> @@ -57,16 +57,9 @@ fcntl(), with all the problems that implies.
> 1.3 Mandatory Locking As A Mount Option
> ---------------------------------------
>
> -Mandatory locking, as described in
> -'Documentation/filesystems/mandatory-locking.rst' was prior to this release a
> -general configuration option that was valid for all mounted filesystems. This
> -had a number of inherent dangers, not the least of which was the ability to
> -freeze an NFS server by asking it to read a file for which a mandatory lock
> -existed.
> -
> -From this release of the kernel, mandatory locking can be turned on and off
> -on a per-filesystem basis, using the mount options 'mand' and 'nomand'.
> -The default is to disallow mandatory locking. The intention is that
> -mandatory locking only be enabled on a local filesystem as the specific need
> -arises.
> +Mandatory locking was prior to this release a general configuration option
> +that was valid for all mounted filesystems. This had a number of inherent
> +dangers, not the least of which was the ability to freeze an NFS server by
> +asking it to read a file for which a mandatory lock existed.
>
> +Such option was dropped in Kernel v5.14.

Looks good. I'll plan to pick this up and (add a Reported-by for Jon,
who noted this a few days ago).

--
Jeff Layton <[email protected]>

2021-10-19 12:07:17

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

On Tue, Oct 19, 2021 at 09:04:20AM +0100, Mauro Carvalho Chehab wrote:

> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/

It'd be a bit easier to put a note in here about what the dependencies
are rather than forcing people to go out to a link to figure out what's
going on unless it's complicated. For a case like this where there's no
dependencies or real relationship between the patches it's probably
better to just not thread everything and send the patches separately to
everyone, the threading is just adding noise and confusion.


Attachments:
(No filename) (691.00 B)
signature.asc (499.00 B)
Download all attachments

2021-10-19 16:08:29

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference

On Tue, Oct 19, 2021 at 4:04 PM Mauro Carvalho Chehab
<[email protected]> wrote:
>
> Changeset f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> renamed: Documentation/devicetree/bindings/mfd/axp20x.txt
> to: Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Acked-by: Chen-Yu Tsai <[email protected]>

2021-10-19 16:55:09

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 00/23] Fix some issues at documentation

On Tue, 19 Oct 2021 09:03:59 +0100, Mauro Carvalho Chehab wrote:
> Hi Jon,
>
> This series is against today's next (next-20211019) and addresses missing
> links to Documentation/*.
>
> The best would be to have the patches applied directly to the trees that
> contain the patches that moved/renamed files, and then apply the
> remaining ones either later during the merge window or just afterwards,
> whatever works best for you.
>
> Regards,
> Mauro
>
> Mauro Carvalho Chehab (23):
> visorbus: fix a copyright symbol that was bad encoded
> libbpf: update index.rst reference
> docs: accounting: update delay-accounting.rst reference
> MAINTAINERS: update arm,vic.yaml reference
> MAINTAINERS: update aspeed,i2c.yaml reference
> MAINTAINERS: update faraday,ftrtc010.yaml reference
> MAINTAINERS: update ti,sci.yaml reference
> MAINTAINERS: update intel,ixp46x-rng.yaml reference
> MAINTAINERS: update nxp,imx8-jpeg.yaml reference
> MAINTAINERS: update gemini.yaml reference
> MAINTAINERS: update brcm,unimac-mdio.yaml reference
> MAINTAINERS: update mtd-physmap.yaml reference

Applied patches 3-12.

> Documentation: update vcpu-requests.rst reference
> bpftool: update bpftool-cgroup.rst reference
> docs: translations: zn_CN: irq-affinity.rst: add a missing extension
> docs: translations: zh_CN: memory-hotplug.rst: fix a typo
> docs: fs: locks.rst: update comment about mandatory file locking
> fs: remove a comment pointing to the removed mandatory-locking file
> Documentation/process: fix a cross reference
> dt-bindings: mfd: update x-powers,axp152.yaml reference
> regulator: dt-bindings: update samsung,s2mpa01.yaml reference
> regulator: dt-bindings: update samsung,s5m8767.yaml reference
> dt-bindings: reserved-memory: ramoops: update ramoops.yaml references

2021-10-19 21:23:48

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

Mauro Carvalho Chehab <[email protected]> writes:

> memory_hotplug.rst -> memory-hotplug.rst

Why do I feel we've been switching this around forever...?

> Fixes: 620127548a69 ("docs/zh_CN: add core api memory_hotplug translation")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> Documentation/translations/zh_CN/core-api/memory-hotplug.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
> index 9a204eb196f2..9b2841fb9a5f 100644
> --- a/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
> +++ b/Documentation/translations/zh_CN/core-api/memory-hotplug.rst
> @@ -1,6 +1,6 @@
> .. include:: ../disclaimer-zh_CN.rst
>
> -:Original: Documentation/core-api/memory_hotplug.rst
> +:Original: Documentation/core-api/memory-hotplug.rst
>
> :翻译:

Applied, thanks.

jon

2021-10-19 22:33:57

by Alexei Starovoitov

[permalink] [raw]
Subject: Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

On Tue, Oct 19, 2021 at 2:35 AM Quentin Monnet <[email protected]> wrote:
>
> 2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
> <[email protected]>
> > The file name: Documentation/bpftool-cgroup.rst
> > should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.
> >
> > Update its cross-reference accordingly.
> >
> > Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
> > Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> > ---
> >
> > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
> >
> > tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > index be54b7335a76..617b8084c440 100755
> > --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > @@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
> > """
> > An extractor for bpftool-cgroup.rst.
> > """
> > - filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
> > + filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
> >
> > def get_attach_types(self):
> > return self.get_rst_list('ATTACH_TYPE')
> >
>
> No, this change is incorrect. We have discussed it several times before
> [0][1]. Please drop this patch.

+1

2021-10-20 05:47:22

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH v3 14/23] bpftool: update bpftool-cgroup.rst reference

Em Tue, 19 Oct 2021 15:31:38 -0700
Alexei Starovoitov <[email protected]> escreveu:

> On Tue, Oct 19, 2021 at 2:35 AM Quentin Monnet <[email protected]> wrote:
> >
> > 2021-10-19 09:04 UTC+0100 ~ Mauro Carvalho Chehab
> > <[email protected]>
> > > The file name: Documentation/bpftool-cgroup.rst
> > > should be, instead: tools/bpf/bpftool/Documentation/bpftool-cgroup.rst.
> > >
> > > Update its cross-reference accordingly.
> > >
> > > Fixes: a2b5944fb4e0 ("selftests/bpf: Check consistency between bpftool source, doc, completion")
> > > Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations")
> > > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> > > ---
> > >
> > > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
> > >
> > > tools/testing/selftests/bpf/test_bpftool_synctypes.py | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/testing/selftests/bpf/test_bpftool_synctypes.py b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > > index be54b7335a76..617b8084c440 100755
> > > --- a/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > > +++ b/tools/testing/selftests/bpf/test_bpftool_synctypes.py
> > > @@ -392,7 +392,7 @@ class ManCgroupExtractor(ManPageExtractor):
> > > """
> > > An extractor for bpftool-cgroup.rst.
> > > """
> > > - filename = os.path.join(BPFTOOL_DIR, 'Documentation/bpftool-cgroup.rst')
> > > + filename = os.path.join(BPFTOOL_DIR, 'tools/bpf/bpftool/Documentation/bpftool-cgroup.rst')
> > >
> > > def get_attach_types(self):
> > > return self.get_rst_list('ATTACH_TYPE')
> > >
> >
> > No, this change is incorrect. We have discussed it several times before
> > [0][1]. Please drop this patch.
>
> +1

Sorry, left-over. I dropped two other patches, but forgot to also drop
this one.

Regards,
Mauro

2021-10-20 06:32:17

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

Em Tue, 19 Oct 2021 13:04:59 +0100
Mark Brown <[email protected]> escreveu:

> On Tue, Oct 19, 2021 at 09:04:20AM +0100, Mauro Carvalho Chehab wrote:
>
> > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> It'd be a bit easier to put a note in here about what the dependencies
> are rather than forcing people to go out to a link to figure out what's
> going on unless it's complicated.
>
> For a case like this where there's no
> dependencies or real relationship between the patches it's probably
> better to just not thread everything and send the patches separately to
> everyone, the threading is just adding noise and confusion.

It is not that easy, unfortunately. On some cases (specially due to
DT binding renames) some patches change the context of a hunk, affecting
a subsequent patch.

I tried a couple of times in the past to send the patches individually,
but that was messier, as there was harder for people to apply them,
as, instead of running b4 just once to get everything, maintainers
would need to apply each patch individually. Also, there were cases
where the patch order would be relevant, due to context changes.

-

Btw, talking about what it would be easier, the best procedure to
adopt is to run:

./scripts/documentation-file-ref-check

Before sending/applying patches touching documents.

That would avoid the need of such fixup patches ;-)

Unfortunately, in the specific case of dt-bindings, things are not
that easy, as doc changes usually go via one tree, while references
to them come from other places.

Regards,
Mauro

2021-10-20 11:14:50

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

On Wed, Oct 20, 2021 at 07:30:13AM +0100, Mauro Carvalho Chehab wrote:
> Mark Brown <[email protected]> escreveu:

> > For a case like this where there's no
> > dependencies or real relationship between the patches it's probably
> > better to just not thread everything and send the patches separately to
> > everyone, the threading is just adding noise and confusion.

> It is not that easy, unfortunately. On some cases (specially due to
> DT binding renames) some patches change the context of a hunk, affecting
> a subsequent patch.

If that's the case then the cover letter really needs work to make this
clear, I couldn't tell that there was any risk of dependencies nor would
I expect any for such trivial changes.

> I tried a couple of times in the past to send the patches individually,
> but that was messier, as there was harder for people to apply them,
> as, instead of running b4 just once to get everything, maintainers
> would need to apply each patch individually. Also, there were cases
> where the patch order would be relevant, due to context changes.

You could also send a per subsystem series if there's a concern about it
being hard to pick up individual patches.


Attachments:
(No filename) (1.19 kB)
signature.asc (499.00 B)
Download all attachments

2021-10-21 12:15:12

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v3 20/23] dt-bindings: mfd: update x-powers,axp152.yaml reference

On Tue, 19 Oct 2021, Mauro Carvalho Chehab wrote:

> Changeset f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> renamed: Documentation/devicetree/bindings/mfd/axp20x.txt
> to: Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: f38d3e404326 ("dt-bindings: mfd: Convert X-Powers AXP binding to a schema")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
>
> Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 2 +-

This file no longer exists.

If it's still relevant, please rebase onto Linux -next and resubmit.

See this commit for details:

dt-bindings: gpio: Convert X-Powers AXP209 GPIO binding to a schema

> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> index fc42b2caa06d..538f04e60ff9 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> @@ -17,7 +17,7 @@ Required properties:
> - gpio-controller: Marks the device node as a GPIO controller.
>
> This node must be a subnode of the axp20x PMIC, documented in
> -Documentation/devicetree/bindings/mfd/axp20x.txt
> +Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>
> Example:
>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

2021-10-24 21:55:42

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v3 06/23] MAINTAINERS: update faraday,ftrtc010.yaml reference

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<[email protected]> wrote:

> Changeset 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
> renamed: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
> to: Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: 8df65d4adca6 ("dt-bindings: convert rtc/faraday,ftrtc01 to yaml")
> Reviewed-by: Linus Walleij <[email protected]>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-10-24 22:12:11

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference

On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
<[email protected]> wrote:

> Changeset b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> renamed: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
> to: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml.
>
> Update its cross-reference accordingly.
>
> Fixes: b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> Reviewed-by: Linus Walleij <[email protected]>
> Acked-by: Sudeep Holla <[email protected]>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

I suppose Marc Z could merge this into the irqchips tree?

Yours,
Linus Walleij

2021-10-25 12:36:58

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 04/23] MAINTAINERS: update arm,vic.yaml reference

On Sun, Oct 24, 2021 at 5:08 PM Linus Walleij <[email protected]> wrote:
>
> On Tue, Oct 19, 2021 at 10:04 AM Mauro Carvalho Chehab
> <[email protected]> wrote:
>
> > Changeset b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> > renamed: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt
> > to: Documentation/devicetree/bindings/interrupt-controller/arm,vic.yaml.
> >
> > Update its cross-reference accordingly.
> >
> > Fixes: b7705ba6d0c4 ("dt-bindings: interrupt-controller: Convert ARM VIC to json-schema")
> > Reviewed-by: Linus Walleij <[email protected]>
> > Acked-by: Sudeep Holla <[email protected]>
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> I suppose Marc Z could merge this into the irqchips tree?

I already applied all these MAINTAINERS fixes.

Rob

2021-10-27 16:42:44

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v3 21/23] regulator: dt-bindings: update samsung,s2mpa01.yaml reference

On Wed, Oct 20, 2021 at 07:30:13AM +0100, Mauro Carvalho Chehab wrote:
> Em Tue, 19 Oct 2021 13:04:59 +0100
> Mark Brown <[email protected]> escreveu:
>
> > On Tue, Oct 19, 2021 at 09:04:20AM +0100, Mauro Carvalho Chehab wrote:
> >
> > > To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > > See [PATCH v3 00/23] at: https://lore.kernel.org/all/[email protected]/
> >
> > It'd be a bit easier to put a note in here about what the dependencies
> > are rather than forcing people to go out to a link to figure out what's
> > going on unless it's complicated.
> >
> > For a case like this where there's no
> > dependencies or real relationship between the patches it's probably
> > better to just not thread everything and send the patches separately to
> > everyone, the threading is just adding noise and confusion.
>
> It is not that easy, unfortunately. On some cases (specially due to
> DT binding renames) some patches change the context of a hunk, affecting
> a subsequent patch.

Those should be reduced now. I've been checking the renames since early
August. July really, but MAINTAINERS was not getting checked initially.


> I tried a couple of times in the past to send the patches individually,
> but that was messier, as there was harder for people to apply them,
> as, instead of running b4 just once to get everything, maintainers
> would need to apply each patch individually. Also, there were cases
> where the patch order would be relevant, due to context changes.

Just spliting between in Linus' tree and only in next would help me. The
former I know I can just apply.

> Btw, talking about what it would be easier, the best procedure to
> adopt is to run:
>
> ./scripts/documentation-file-ref-check
>
> Before sending/applying patches touching documents.

Good luck with that. :(

> That would avoid the need of such fixup patches ;-)
>
> Unfortunately, in the specific case of dt-bindings, things are not
> that easy, as doc changes usually go via one tree, while references
> to them come from other places.
>
> Regards,
> Mauro
>

2021-11-01 07:50:17

by Alex Shi

[permalink] [raw]
Subject: Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

On Wed, Oct 20, 2021 at 3:08 PM David Hildenbrand <[email protected]> wrote:
>
> Dumb question that probably has been asked a couple of times already:
> why do we even maintain a translated doc in-tree?
>
> Every time I do an update on the original doc, I for sure can only guess
> which translated parts need updating. And I really can only update when
> "deleting", not when rewording/adding. So we'll be left with stale doc
> that will have to be updated manually by $whoever.

cc to the translation maintainers and translator would be helpful?

> I don't feel very
> confident about this. No translated doc is better than outdated
> translated doc.

Uh, I don't know other languages, but in Chinese, 15 years before
translated books are still selling well in China. :)
https://item.jd.com/1075130482.html -> Linux device driver
https://item.jd.com/10100237.html -> Understanding linux kernel

Thanks
Alex

>
> This feels like something that should be maintained out of tree. My 2 cents.
>
> --
> Thanks,
>
> David / dhildenb
>

2021-11-01 13:40:39

by teng sterling

[permalink] [raw]
Subject: Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

Alex Shi <[email protected]> 于2021年11月1日周一 下午3:48写道:
>
> On Wed, Oct 20, 2021 at 3:08 PM David Hildenbrand <[email protected]> wrote:
> >
> > Dumb question that probably has been asked a couple of times already:
> > why do we even maintain a translated doc in-tree?
> >
> > Every time I do an update on the original doc, I for sure can only guess
> > which translated parts need updating. And I really can only update when
Dear David

Thank you very much for your contribution, in fact, we are always updating the
translations and improving the speed of the sync, so If you are not
good at Chinese
and want to get the sync faster, please CC us when you send the patch.

> > "deleting", not when rewording/adding. So we'll be left with stale doc
> > that will have to be updated manually by $whoever.
>
> cc to the translation maintainers and translator would be helpful?
Alex,Maybe we should provide a translation guide in English, e.g::

Dear developers, if you have trouble updating the Chinese documentation after
updating the original documentation, please CC the translator of
that documentation
and the maintainer of the Chinese documentation, and the relevant
documentation
will be updated soon.

>
> > I don't feel very
> > confident about this. No translated doc is better than outdated
> > translated doc.
>
> Uh, I don't know other languages, but in Chinese, 15 years before
> translated books are still selling well in China. :)
> https://item.jd.com/1075130482.html -> Linux device driver
> https://item.jd.com/10100237.html -> Understanding linux kernel
Yes, I just bought a LDD3 last week.! >_<


Thanks,
Yanteng

2021-11-01 14:02:09

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH v3 16/23] docs: translations: zh_CN: memory-hotplug.rst: fix a typo

On 01.11.21 14:38, teng sterling wrote:
> Alex Shi <[email protected]> 于2021年11月1日周一 下午3:48写道:
>>
>> On Wed, Oct 20, 2021 at 3:08 PM David Hildenbrand <[email protected]> wrote:
>>>
>>> Dumb question that probably has been asked a couple of times already:
>>> why do we even maintain a translated doc in-tree?
>>>
>>> Every time I do an update on the original doc, I for sure can only guess
>>> which translated parts need updating. And I really can only update when
> Dear David
>
> Thank you very much for your contribution, in fact, we are always updating the
> translations and improving the speed of the sync, so If you are not
> good at Chinese
> and want to get the sync faster, please CC us when you send the patch.
>

It would be great if we would get this suggestion automatically, e.g.,
via get_maintainers.pl --- maybe that's already done, I didn't check.

Personally, I don't speak/read any Chinese, so I'm mostly lost staring
at the Chinese translation. :)


>>> "deleting", not when rewording/adding. So we'll be left with stale doc
>>> that will have to be updated manually by $whoever.
>>
>> cc to the translation maintainers and translator would be helpful?
> Alex,Maybe we should provide a translation guide in English, e.g::
>
> Dear developers, if you have trouble updating the Chinese documentation after
> updating the original documentation, please CC the translator of
> that documentation
> and the maintainer of the Chinese documentation, and the relevant
> documentation
> will be updated soon.
>
>>
>>> I don't feel very
>>> confident about this. No translated doc is better than outdated
>>> translated doc.
>>
>> Uh, I don't know other languages, but in Chinese, 15 years before
>> translated books are still selling well in China. :)
>> https://item.jd.com/1075130482.html -> Linux device driver
>> https://item.jd.com/10100237.html -> Understanding linux kernel
> Yes, I just bought a LDD3 last week.! >_<

Yes, these books in particular are still of a lot of value, although
outdated. :)

The difference is that when you translate a book, there is a
date/version attached, meaning, the original book was for example based
on kernel v2.XXX. Once you translate the book, it's simply based on the
same kernel version.

The in-tree doc is similar. You can access the v5.14 doc for example
easily via https://www.kernel.org/doc/html/v5.14/. And the Chinese
version via https://www.kernel.org/doc/html/v5.14/translations/zh_CN/.

If I as a developer perform a doc update in v5.14, and the translation
isn't updated until the end of the same release, the versioned
documentation will be out of sync. And that happens automatically with a
new release.

With an out-of-tree translation, there wouldn't really be an issue. Once
everything was translated (brought up-to-date), you would mark it has
"fully translated doc of v5.15" manually and release it.

But maybe the translation maintainers already take proper care of
updating any translation just before the new kernel is released.

So just my comment after stumbling over in-tree doc translations.

--
Thanks,

David / dhildenb