2018-08-01 07:46:14

by agajjar

Subject: [PATCH] arm64: dts: allwinner: a64: add csi regulator to sopine dts

sopine board has a csi. enable supply dvdd-1v8-csi, dovdd-2v8-csi and
avdd-2v8-csi on board to access external camera connected to it.

Signed-off-by: Akash Gajjar <[email protected]>
---
.../arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
index 43418bd..256229b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
@@ -68,6 +68,13 @@

#include "axp803.dtsi"

+&reg_aldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-name = "dovdd-csi";
+};
+
&reg_aldo2 {
regulator-always-on;
regulator-min-microvolt = <1800000>;
@@ -112,6 +119,13 @@
regulator-name = "vdd-sys";
};

+&reg_dldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-name = "avdd-csi";
+};
+
&reg_eldo1 {
regulator-always-on;
regulator-min-microvolt = <1800000>;
@@ -119,6 +133,13 @@
regulator-name = "vdd-1v8-lpddr";
};

+&reg_eldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vdd-csi";
+};
+
&reg_fldo1 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
--
2.7.4

2018-08-07 04:04:59

by Chen-Yu Tsai

Subject: Re: [PATCH] arm64: dts: allwinner: a64: add csi regulator to sopine dts

On Wed, Aug 1, 2018 at 3:43 PM, Akash Gajjar <[email protected]> wrote:
> sopine board has a csi. enable supply dvdd-1v8-csi, dovdd-2v8-csi and
> avdd-2v8-csi on board to access external camera connected to it.

Unless there are other uses beyond supplying the camera module, this is not
going to be accepted. Enabling power to the camera should be in the same
patch as enabling the camera itself. And since it is a module, it should
be an overlay file.


ChenYu


> Signed-off-by: Akash Gajjar <[email protected]>
> ---
> .../arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> index 43418bd..256229b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi
> @@ -68,6 +68,13 @@
>
> #include "axp803.dtsi"
>
> +&reg_aldo1 {
> + regulator-always-on;
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + regulator-name = "dovdd-csi";
> +};
> +
> &reg_aldo2 {
> regulator-always-on;
> regulator-min-microvolt = <1800000>;
> @@ -112,6 +119,13 @@
> regulator-name = "vdd-sys";
> };
>
> +&reg_dldo3 {
> + regulator-always-on;
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + regulator-name = "avdd-csi";
> +};
> +
> &reg_eldo1 {
> regulator-always-on;
> regulator-min-microvolt = <1800000>;
> @@ -119,6 +133,13 @@
> regulator-name = "vdd-1v8-lpddr";
> };
>
> +&reg_eldo3 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-name = "vdd-csi";
> +};
> +
> &reg_fldo1 {
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> --
> 2.7.4
>