2020-10-28 22:34:30

by Krzysztof Kozlowski

Subject: [RESEND PATCH 05/42] mfd: axp20x: use PLATFORM_DEVID_NONE

Use PLATFORM_DEVID_NONE define instead of "-1" value because:
- it brings some meaning,
- it might point attention why auto device ID was not used.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/mfd/axp20x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index aa59496e4376..70aa538a4b64 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -967,7 +967,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
return ret;
}

- ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
+ ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_NONE, axp20x->cells,
axp20x->nr_cells, NULL, 0, NULL);

if (ret) {
--
2.25.1

2020-10-29 08:56:26

by Chen-Yu Tsai

Subject: Re: [RESEND PATCH 05/42] mfd: axp20x: use PLATFORM_DEVID_NONE

On Thu, Oct 29, 2020 at 6:30 AM Krzysztof Kozlowski <[email protected]> wrote:
>
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>

Acked-by: Chen-Yu Tsai <[email protected]>