The drm_driver lastclose callback is called when the last userspace
DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
the fbdev console otherwise the fbdev console will stop working.
Signed-off-by: Jonathan Liu <[email protected]>
---
Changes for v2:
- Rename sun4i_drm_lastclose to sun4i_drv_lastclose
drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index abc7d8fe06b4..a45a627283a1 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -25,12 +25,20 @@
#include "sun4i_framebuffer.h"
#include "sun4i_tcon.h"
+static void sun4i_drv_lastclose(struct drm_device *dev)
+{
+ struct sun4i_drv *drv = dev->dev_private;
+
+ drm_fbdev_cma_restore_mode(drv->fbdev);
+}
+
DEFINE_DRM_GEM_CMA_FOPS(sun4i_drv_fops);
static struct drm_driver sun4i_drv_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | DRIVER_ATOMIC,
/* Generic Operations */
+ .lastclose = sun4i_drv_lastclose,
.fops = &sun4i_drv_fops,
.name = "sun4i-drm",
.desc = "Allwinner sun4i Display Engine",
--
2.13.2
On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <[email protected]> wrote:
> The drm_driver lastclose callback is called when the last userspace
> DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> the fbdev console otherwise the fbdev console will stop working.
>
> Signed-off-by: Jonathan Liu <[email protected]>
This should have
Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
Otherwise,
Reviewed-by: Chen-Yu Tsai <[email protected]>
On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote:
> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <[email protected]> wrote:
> > The drm_driver lastclose callback is called when the last userspace
> > DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
> > the fbdev console otherwise the fbdev console will stop working.
> >
> > Signed-off-by: Jonathan Liu <[email protected]>
>
> This should have
>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>
> Otherwise,
>
> Reviewed-by: Chen-Yu Tsai <[email protected]>
And it should be sent to stable too.
Can you resend it?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Hi Maxime,
On 10 July 2017 at 16:44, Maxime Ripard
<[email protected]> wrote:
> On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote:
>> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <[email protected]> wrote:
>> > The drm_driver lastclose callback is called when the last userspace
>> > DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
>> > the fbdev console otherwise the fbdev console will stop working.
>> >
>> > Signed-off-by: Jonathan Liu <[email protected]>
>>
>> This should have
>>
>> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>>
>> Otherwise,
>>
>> Reviewed-by: Chen-Yu Tsai <[email protected]>
>
> And it should be sent to stable too.
>
> Can you resend it?
Will do.
>
> Thanks!
> Maxime
>
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
Regards,
Jonathan
On Mon, Jul 10, 2017 at 8:44 AM, Maxime Ripard
<[email protected]> wrote:
> On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote:
>> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <[email protected]> wrote:
>> > The drm_driver lastclose callback is called when the last userspace
>> > DRM client has closed. Call drm_fbdev_cma_restore_mode to restore
>> > the fbdev console otherwise the fbdev console will stop working.
>> >
>> > Signed-off-by: Jonathan Liu <[email protected]>
>>
>> This should have
>>
>> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
>>
>> Otherwise,
>>
>> Reviewed-by: Chen-Yu Tsai <[email protected]>
>
> And it should be sent to stable too.
>
> Can you resend it?
Fyi but patchwork auto-adds these tags. Feels a bit like overkill
asking for a resend for something you can trivially add yourself ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch