2020-02-12 10:48:00

by Johan Hovold

[permalink] [raw]
Subject: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

The sram-node compatible properties have mistakingly combined the
model-specific string with the generic "mtd-ram" string.

Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
"cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
not present in any binding.

The physmap driver will however bind to platform devices that specify
"mtd-ram".

Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
Cc: Sanchayan Maity <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Shawn Guo <[email protected]>
Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
index cd075621de52..84fcc203a2e4 100644
--- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
@@ -275,7 +275,7 @@ &weim {

/* SRAM on Colibri nEXT_CS0 */
sram@0,0 {
- compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+ compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
reg = <0 0 0x00010000>;
#address-cells = <1>;
#size-cells = <1>;
@@ -286,7 +286,7 @@ sram@0,0 {

/* SRAM on Colibri nEXT_CS1 */
sram@1,0 {
- compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+ compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
reg = <1 0 0x00010000>;
#address-cells = <1>;
#size-cells = <1>;
--
2.24.1


2020-02-12 11:03:23

by Oleksandr Suvorov

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

On Wed, Feb 12, 2020 at 12:46 PM Johan Hovold <[email protected]> wrote:
>
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
>
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
>
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
>
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <[email protected]>
> Cc: Marcel Ziswiler <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Oleksandr Suvorov <[email protected]>

> ---
> arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> index cd075621de52..84fcc203a2e4 100644
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -275,7 +275,7 @@ &weim {
>
> /* SRAM on Colibri nEXT_CS0 */
> sram@0,0 {
> - compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> + compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
> reg = <0 0 0x00010000>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -286,7 +286,7 @@ sram@0,0 {
>
> /* SRAM on Colibri nEXT_CS1 */
> sram@1,0 {
> - compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> + compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
> reg = <1 0 0x00010000>;
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.24.1
>


--
Best regards

Oleksandr Suvorov
[email protected]

2020-02-17 06:37:36

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

On Wed, Feb 12, 2020 at 11:46:29AM +0100, Johan Hovold wrote:
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
>
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
>
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
>
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <[email protected]>
> Cc: Marcel Ziswiler <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>

Applied, thanks.