2022-01-13 07:40:23

by Christian Gmeiner

Subject: [PATCH] net: fastboot: make UDP port net: configurable

The fastboot protocol uses per default the UDP port 5554. In some cases
it might be needed to change the used port. The fastboot utility provides
a way to specifiy an other port number to use already.

fastboot -s udp:192.168.1.76:1234 boot fastboot.img

Signed-off-by: Christian Gmeiner <[email protected]>
---
drivers/fastboot/Kconfig | 7 +++++++
net/fastboot.c | 5 +----
2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
index d5e4a02098..b97c67bf60 100644
--- a/drivers/fastboot/Kconfig
+++ b/drivers/fastboot/Kconfig
@@ -21,6 +21,13 @@ config UDP_FUNCTION_FASTBOOT
help
This enables the fastboot protocol over UDP.

+config UDP_FUNCTION_FASTBOOT_PORT
+ depends on UDP_FUNCTION_FASTBOOT
+ int "Define FASTBOOT UDP port"
+ default 5554
+ help
+ The fastboot protocol requires a UDP port number.
+
if FASTBOOT

config FASTBOOT_BUF_ADDR
diff --git a/net/fastboot.c b/net/fastboot.c
index 7e7a601b9f..139233b86c 100644
--- a/net/fastboot.c
+++ b/net/fastboot.c
@@ -9,9 +9,6 @@
#include <net.h>
#include <net/fastboot.h>

-/* Fastboot port # defined in spec */
-#define WELL_KNOWN_PORT 5554
-
enum {
FASTBOOT_ERROR = 0,
FASTBOOT_QUERY = 1,
@@ -310,7 +307,7 @@ void fastboot_start_server(void)
printf("Using %s device\n", eth_get_name());
printf("Listening for fastboot command on %pI4\n", &net_ip);

- fastboot_our_port = WELL_KNOWN_PORT;
+ fastboot_our_port = CONFIG_UDP_FUNCTION_FASTBOOT_PORT;

#if CONFIG_IS_ENABLED(FASTBOOT_FLASH)
fastboot_set_progress_callback(fastboot_timed_send_info);
--
2.34.1

2022-01-13 12:02:09

by Heiko Schocher

Subject: Re: [PATCH] net: fastboot: make UDP port net: configurable

Hello Christian,

On 13.01.22 08:40, Christian Gmeiner wrote:
> The fastboot protocol uses per default the UDP port 5554. In some cases
> it might be needed to change the used port. The fastboot utility provides
> a way to specifiy an other port number to use already.
>
> fastboot -s udp:192.168.1.76:1234 boot fastboot.img
>
> Signed-off-by: Christian Gmeiner <[email protected]>
> ---
> drivers/fastboot/Kconfig | 7 +++++++
> net/fastboot.c | 5 +----
> 2 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Heiko Schocher <[email protected]>

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]

2022-01-16 06:45:20

by Ramon Fried

Subject: Re: [PATCH] net: fastboot: make UDP port net: configurable

On Thu, Jan 13, 2022 at 2:02 PM Heiko Schocher <[email protected]> wrote:
>
> Hello Christian,
>
> On 13.01.22 08:40, Christian Gmeiner wrote:
> > The fastboot protocol uses per default the UDP port 5554. In some cases
> > it might be needed to change the used port. The fastboot utility provides
> > a way to specifiy an other port number to use already.
> >
> > fastboot -s udp:192.168.1.76:1234 boot fastboot.img
> >
> > Signed-off-by: Christian Gmeiner <[email protected]>
> > ---
> > drivers/fastboot/Kconfig | 7 +++++++
> > net/fastboot.c | 5 +----
> > 2 files changed, 8 insertions(+), 4 deletions(-)
>
> Reviewed-by: Heiko Schocher <[email protected]>
>
> bye,
> Heiko
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Reviewed-by: Ramon Fried <[email protected]>

2022-01-16 06:48:01

by Ramon Fried

Subject: Re: [PATCH] net: fastboot: make UDP port net: configurable

On Sat, Jan 15, 2022 at 1:58 PM Ramon Fried <[email protected]> wrote:
>
> On Thu, Jan 13, 2022 at 2:02 PM Heiko Schocher <[email protected]> wrote:
> >
> > Hello Christian,
> >
> > On 13.01.22 08:40, Christian Gmeiner wrote:
> > > The fastboot protocol uses per default the UDP port 5554. In some cases
> > > it might be needed to change the used port. The fastboot utility provides
> > > a way to specifiy an other port number to use already.
> > >
> > > fastboot -s udp:192.168.1.76:1234 boot fastboot.img
> > >
> > > Signed-off-by: Christian Gmeiner <[email protected]>
> > > ---
> > > drivers/fastboot/Kconfig | 7 +++++++
> > > net/fastboot.c | 5 +----
> > > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > Reviewed-by: Heiko Schocher <[email protected]>
> >
> > bye,
> > Heiko
> > --
> > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
> Reviewed-by: Ramon Fried <[email protected]>
Applied to u-boot-net/next
Thanks !