2023-02-18 19:56:56

by Ramon Fried

Subject: amba pl011 non amba/sbsa driver

Hi.
Our upcoming SOC is using pl011 ip, but we have a different NOC than
AMBA and we don't want to use the SBSA, as it provides limited
functionality in the UART.

My question is should we develop a new driver or add more
functionality to the current driver.
The pl011 driver is a bit messy, and the functionality we actually
need is actually supported in the current driver, but I can't
differentiate my HW using AMBA id.

If a change will be more suitable in the driver, my plan is to add
support for an oe_device_id table along with an amba_device_id table
for generic amba pl011 drivers.
Does this make sense ?

Thanks,
Ramon.

2023-02-19 07:24:56

by Greg Kroah-Hartman

Subject: Re: amba pl011 non amba/sbsa driver

On Sat, Feb 18, 2023 at 09:56:39PM +0200, Ramon Fried wrote:
> Hi.
> Our upcoming SOC is using pl011 ip, but we have a different NOC than
> AMBA and we don't want to use the SBSA, as it provides limited
> functionality in the UART.
>
> My question is should we develop a new driver or add more
> functionality to the current driver.
> The pl011 driver is a bit messy, and the functionality we actually
> need is actually supported in the current driver, but I can't
> differentiate my HW using AMBA id.

If it's the same IP block, please use the same driver. That way it will
be easier to maintain over the long-term.

thanks,

greg k-h