2016-12-09 10:11:44

by Yegor Yefremov

[permalink] [raw]
Subject: [PATCH] Documentation: ti-syscon-reset: fix header path

From: Yegor Yefremov <[email protected]>

'include' was missing from path.

Signed-off-by: Yegor Yefremov <[email protected]>
---
Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
index 164c7f3..5b20e20 100644
--- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
+++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
@@ -44,7 +44,7 @@ Required properties:
reset status register
Cell #7 : Flags used to control reset behavior,
availible flags defined in the DT include
- file <dt-bindings/reset/ti-syscon.h>
+ file <include/dt-bindings/reset/ti-syscon.h>

SysCon Reset Consumer Nodes
===========================
--
2.1.4


2016-12-12 18:40:26

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] Documentation: ti-syscon-reset: fix header path

On Fri, Dec 09, 2016 at 11:11:27AM +0100, [email protected] wrote:
> From: Yegor Yefremov <[email protected]>
>
> 'include' was missing from path.
>
> Signed-off-by: Yegor Yefremov <[email protected]>
> ---
> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> index 164c7f3..5b20e20 100644
> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> @@ -44,7 +44,7 @@ Required properties:
> reset status register
> Cell #7 : Flags used to control reset behavior,
> availible flags defined in the DT include
> - file <dt-bindings/reset/ti-syscon.h>
> + file <include/dt-bindings/reset/ti-syscon.h>

There's pretty much equal mixture of include or not. Not really much
point in fixing 1 instance if there's no clear correct way. Given it is
written with <...>, that matches how you write the include statement.

Rob

2016-12-12 19:52:49

by Yegor Yefremov

[permalink] [raw]
Subject: Re: [PATCH] Documentation: ti-syscon-reset: fix header path

On Mon, Dec 12, 2016 at 7:40 PM, Rob Herring <[email protected]> wrote:
> On Fri, Dec 09, 2016 at 11:11:27AM +0100, [email protected] wrote:
>> From: Yegor Yefremov <[email protected]>
>>
>> 'include' was missing from path.
>>
>> Signed-off-by: Yegor Yefremov <[email protected]>
>> ---
>> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> index 164c7f3..5b20e20 100644
>> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> @@ -44,7 +44,7 @@ Required properties:
>> reset status register
>> Cell #7 : Flags used to control reset behavior,
>> availible flags defined in the DT include
>> - file <dt-bindings/reset/ti-syscon.h>
>> + file <include/dt-bindings/reset/ti-syscon.h>
>
> There's pretty much equal mixture of include or not. Not really much
> point in fixing 1 instance if there's no clear correct way. Given it is
> written with <...>, that matches how you write the include statement.

OK I see the point of omitting include now. I was looking at this from
VIM point of view. I cannot automatically jump to the file via 'gf'.

Yegor