This chip is (nearly) identical to the Winbond w25q64 which is
already supported by Linux. Compared to the w25q64, the 'jv'
does not support Quad SPI mode, and has a different JEDEC ID.
To: Tudor Ambarus <[email protected]>
To: Miquel Raynal <[email protected]>
To: Richard Weinberger <[email protected]>
To: Vignesh Raghavendra <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Sven Van Asbroeck <[email protected]>
---
Tree: next-20200613
drivers/mtd/spi-nor/winbond.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 5062af10f138..18bdff02f57f 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
{ "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
{ "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
+ { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
{ "w25q64dw", INFO(0xef6017, 0, 64 * 1024, 128,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
--
2.17.1
Is there any way I can help to get this patch into mainline?
Thank you,
Sven
On Sat, Jun 13, 2020 at 7:53 PM Sven Van Asbroeck <[email protected]> wrote:
>
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.
>
> To: Tudor Ambarus <[email protected]>
> To: Miquel Raynal <[email protected]>
> To: Richard Weinberger <[email protected]>
> To: Vignesh Raghavendra <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Sven Van Asbroeck <[email protected]>
> ---
>
> Tree: next-20200613
>
> drivers/mtd/spi-nor/winbond.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> + { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64dw", INFO(0xef6017, 0, 64 * 1024, 128,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> --
> 2.17.1
>
Hi Tudor,
On Mon, Jun 29, 2020 at 8:50 AM <[email protected]> wrote:
>
> I'm reading the following datasheet:
> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
>
> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
> please specify in the commit message with which controller you did the tests.
>
Good point !
Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which
does not support dual or quad mode. So I cannot possibly test this :)
How would you like to proceed? Should I keep this as a private patch, and
wait until someone comes along who can test this on more capable
controller h/w ?
Or should I re-spin the patch without the flags?
Cheers,
Sven