2018-05-22 17:34:11

by Gustavo A. R. Silva

Subject: [PATCH] au8522: remove duplicate code

This code has been there for nine years now, and it has been
working "good enough" since then [1].

Remove duplicate code by getting rid of the if-else statement.

[1] https://marc.info/?l=linux-kernel&m=152693550225081&w=2

Cc: Devin Heitmueller <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/media/dvb-frontends/au8522_decoder.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_decoder.c
index 343dc92..f285096 100644
--- a/drivers/media/dvb-frontends/au8522_decoder.c
+++ b/drivers/media/dvb-frontends/au8522_decoder.c
@@ -280,14 +280,12 @@ static void setup_decoder_defaults(struct au8522_state *state, bool is_svideo)
AU8522_TOREGAAGC_REG0E5H_CVBS);
au8522_writereg(state, AU8522_REG016H, AU8522_REG016H_CVBS);

- if (is_svideo) {
- /* Despite what the table says, for the HVR-950q we still need
- to be in CVBS mode for the S-Video input (reason unknown). */
- /* filter_coef_type = 3; */
- filter_coef_type = 5;
- } else {
- filter_coef_type = 5;
- }
+ /*
+ * Despite what the table says, for the HVR-950q we still need
+ * to be in CVBS mode for the S-Video input (reason unknown).
+ */
+ /* filter_coef_type = 3; */
+ filter_coef_type = 5;

/* Load the Video Decoder Filter Coefficients */
for (i = 0; i < NUM_FILTER_COEF; i++) {
--
2.7.4

2018-05-22 17:20:05

by Devin Heitmueller

Subject: Re: [PATCH] au8522: remove duplicate code

Reviewed-by: Devin Heitmueller <[email protected]>

Devin

On Tue, May 22, 2018 at 1:09 PM, Gustavo A. R. Silva
<[email protected]> wrote:
> This code has been there for nine years now, and it has been
> working "good enough" since then [1].
>
> Remove duplicate code by getting rid of the if-else statement.
>
> [1] https://marc.info/?l=linux-kernel&m=152693550225081&w=2
>
> Cc: Devin Heitmueller <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/media/dvb-frontends/au8522_decoder.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_decoder.c
> index 343dc92..f285096 100644
> --- a/drivers/media/dvb-frontends/au8522_decoder.c
> +++ b/drivers/media/dvb-frontends/au8522_decoder.c
> @@ -280,14 +280,12 @@ static void setup_decoder_defaults(struct au8522_state *state, bool is_svideo)
> AU8522_TOREGAAGC_REG0E5H_CVBS);
> au8522_writereg(state, AU8522_REG016H, AU8522_REG016H_CVBS);
>
> - if (is_svideo) {
> - /* Despite what the table says, for the HVR-950q we still need
> - to be in CVBS mode for the S-Video input (reason unknown). */
> - /* filter_coef_type = 3; */
> - filter_coef_type = 5;
> - } else {
> - filter_coef_type = 5;
> - }
> + /*
> + * Despite what the table says, for the HVR-950q we still need
> + * to be in CVBS mode for the S-Video input (reason unknown).
> + */
> + /* filter_coef_type = 3; */
> + filter_coef_type = 5;
>
> /* Load the Video Decoder Filter Coefficients */
> for (i = 0; i < NUM_FILTER_COEF; i++) {
> --
> 2.7.4
>



--
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com