Guenter,
On Thu, Jan 08, 2015 at 08:48:40PM -0800, Guenter Roeck wrote:
> On 01/08/2015 10:05 AM, Nishanth Menon wrote:
> > Allow gpio-fan to be used as thermal cooling device for platforms that
> > use GPIO maps to control fans.
> >
> > As part of this change, we make the shutdown and remove logic the same
> > as well.
> >
> > Signed-off-by: Nishanth Menon <[email protected]>
> > ---
>
> Applied to -next.
What is the target kernel version for this change? It didn't make
4.0-rc1
BR,
Eduardo Valentin
>
> Thanks,
> Guenter
>
On Tue, Feb 24, 2015 at 03:29:35PM -0400, Eduardo Valentin wrote:
> Guenter,
>
> On Thu, Jan 08, 2015 at 08:48:40PM -0800, Guenter Roeck wrote:
> > On 01/08/2015 10:05 AM, Nishanth Menon wrote:
> > > Allow gpio-fan to be used as thermal cooling device for platforms that
> > > use GPIO maps to control fans.
> > >
> > > As part of this change, we make the shutdown and remove logic the same
> > > as well.
> > >
> > > Signed-off-by: Nishanth Menon <[email protected]>
> > > ---
> >
> > Applied to -next.
>
> What is the target kernel version for this change? It didn't make
> 4.0-rc1
>
If I recall correctly, I had to pull it because the thermal framework
does not provide hooks if disabled. Weird, I am sure I sent an e-mail
about this, but I don't find it right now.
It can't make it in before the hooks are in place, or we'll need
another version with ifdefs around the thermal registration code.
Guenter
On Tue, Feb 24, 2015 at 11:55:23AM -0800, Guenter Roeck wrote:
> On Tue, Feb 24, 2015 at 03:29:35PM -0400, Eduardo Valentin wrote:
> > Guenter,
> >
> > On Thu, Jan 08, 2015 at 08:48:40PM -0800, Guenter Roeck wrote:
> > > On 01/08/2015 10:05 AM, Nishanth Menon wrote:
> > > > Allow gpio-fan to be used as thermal cooling device for platforms that
> > > > use GPIO maps to control fans.
> > > >
> > > > As part of this change, we make the shutdown and remove logic the same
> > > > as well.
> > > >
> > > > Signed-off-by: Nishanth Menon <[email protected]>
> > > > ---
> > >
> > > Applied to -next.
> >
> > What is the target kernel version for this change? It didn't make
> > 4.0-rc1
> >
> If I recall correctly, I had to pull it because the thermal framework
> does not provide hooks if disabled. Weird, I am sure I sent an e-mail
> about this, but I don't find it right now.
>
> It can't make it in before the hooks are in place, or we'll need
> another version with ifdefs around the thermal registration code.
Got it!
I applied the fix that Nishanth sent to thermal.h [1]. I am planing to
send it during 4.0 rc cycles.
Thanks for the clarification.
[1] -
https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/commit/?h=fixes&id=12ca7188468ee29c4e717f73db4bf43c90954fc7
>
> Guenter
Eduardo Valentin
On Tue, Feb 24, 2015 at 1:55 PM, Guenter Roeck <[email protected]> wrote:
> On Tue, Feb 24, 2015 at 03:29:35PM -0400, Eduardo Valentin wrote:
>> Guenter,
>>
>> On Thu, Jan 08, 2015 at 08:48:40PM -0800, Guenter Roeck wrote:
>> > On 01/08/2015 10:05 AM, Nishanth Menon wrote:
>> > > Allow gpio-fan to be used as thermal cooling device for platforms that
>> > > use GPIO maps to control fans.
>> > >
>> > > As part of this change, we make the shutdown and remove logic the same
>> > > as well.
>> > >
>> > > Signed-off-by: Nishanth Menon <[email protected]>
>> > > ---
>> >
>> > Applied to -next.
>>
>> What is the target kernel version for this change? It didn't make
>> 4.0-rc1
>>
> If I recall correctly, I had to pull it because the thermal framework
> does not provide hooks if disabled. Weird, I am sure I sent an e-mail
> about this, but I don't find it right now.
>
> It can't make it in before the hooks are in place, or we'll need
> another version with ifdefs around the thermal registration code.
I had posted the required hooks.
https://patchwork.kernel.org/patch/5828261/ -> I think Eduardo picked
this one up.. So once it hits mainline, we should ideally be clear.
--
---
Regards,
Nishanth Menon