2020-04-09 00:04:17

by Barry Song

[permalink] [raw]
Subject: Re: [PATCH v1 23/28] i2c: sirf: convert to devm_platform_ioremap_resource

Dejin Zheng <[email protected]> 于2020年4月8日周三 上午4:39写道:
>
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
>
> Signed-off-by: Dejin Zheng <[email protected]>

Reviewed-by: Barry Song <[email protected]>

> ---
> drivers/i2c/busses/i2c-sirf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
> index fb7a046b3226..269a71b0ee7f 100644
> --- a/drivers/i2c/busses/i2c-sirf.c
> +++ b/drivers/i2c/busses/i2c-sirf.c
> @@ -272,7 +272,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
> {
> struct sirfsoc_i2c *siic;
> struct i2c_adapter *adap;
> - struct resource *mem_res;
> struct clk *clk;
> int bitrate;
> int ctrl_speed;
> @@ -310,8 +309,7 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
> adap = &siic->adapter;
> adap->class = I2C_CLASS_DEPRECATED;
>
> - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - siic->base = devm_ioremap_resource(&pdev->dev, mem_res);
> + siic->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(siic->base)) {
> err = PTR_ERR(siic->base);
> goto out;
> --
> 2.25.0
>