2024-02-01 22:03:23

by Markus Mayer

[permalink] [raw]
Subject: Re: [PATCH v2 2/5] dt-bindings: memory: add two chip-specific compatible string

On Tue, 23 Jan 2024 at 13:23, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 19/01/2024 22:52, Markus Mayer wrote:
> > Add brcm,bcm7278-dpfe-cpu and brcm,bcm7211-dpfe-cpu to the list of
> > acceptable compatible strings.
> >
> > Signed-off-by: Markus Mayer <[email protected]>
> > ---
> > .../devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> > index e2b990e4a792..3f00bc2fd3ec 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> > @@ -16,6 +16,8 @@ properties:
> > - enum:
> > - brcm,bcm7271-dpfe-cpu
> > - brcm,bcm7268-dpfe-cpu
> > + - brcm,bcm7278-dpfe-cpu
> > + - brcm,bcm7211-dpfe-cpu
>
> Let's not make it more random than it already is. Feel free to re-order
> the two entries to have alphabetical order and then place new entries in
> proper places.

Will do.

> Best regards,
> Krzysztof