2022-12-15 15:51:16

by Hugo Villeneuve

[permalink] [raw]
Subject: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

From: Hugo Villeneuve <[email protected]>

Add support for new NXP RTC PCF2131.

Signed-off-by: Hugo Villeneuve <[email protected]>
---
Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
index cde7b1675ead..a8f8c23da4d8 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
@@ -14,7 +14,9 @@ maintainers:

properties:
compatible:
- const: nxp,pcf2127
+ enum:
+ - nxp,pcf2127
+ - nxp,pcf2131

reg:
maxItems: 1
--
2.30.2


2022-12-16 13:48:07

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

On 15/12/2022 16:02, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <[email protected]>
>
> Add support for new NXP RTC PCF2131.
>
> Signed-off-by: Hugo Villeneuve <[email protected]>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-12-19 09:38:14

by Bruno Thomsen

[permalink] [raw]
Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <[email protected]>:
>
> From: Hugo Villeneuve <[email protected]>
>
> Add support for new NXP RTC PCF2131.
>
> Signed-off-by: Hugo Villeneuve <[email protected]>
> ---
> Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..a8f8c23da4d8 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,9 @@ maintainers:
>
> properties:
> compatible:
> - const: nxp,pcf2127
> + enum:
> + - nxp,pcf2127
> + - nxp,pcf2131

The enum is incomplete as pcf2127_of_match struct also contains:
nxp,pcf2129
ncp,pca2129

/Bruno

>
> reg:
> maxItems: 1
> --
> 2.30.2
>

2022-12-19 17:09:24

by Hugo Villeneuve

[permalink] [raw]
Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

On Mon, 19 Dec 2022 10:14:10 +0100
Bruno Thomsen <[email protected]> wrote:

> Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <[email protected]>:
> >
> > From: Hugo Villeneuve <[email protected]>
> >
> > Add support for new NXP RTC PCF2131.
> >
> > Signed-off-by: Hugo Villeneuve <[email protected]>
> > ---
> > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..a8f8c23da4d8 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,9 @@ maintainers:
> >
> > properties:
> > compatible:
> > - const: nxp,pcf2127
> > + enum:
> > + - nxp,pcf2127
> > + - nxp,pcf2131
>
> The enum is incomplete as pcf2127_of_match struct also contains:
> nxp,pcf2129
> ncp,pca2129
>
> /Bruno

Hi,
if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...

Hugo.


> > reg:
> > maxItems: 1
> > --
> > 2.30.2
> >
>


--
Hugo Villeneuve <[email protected]>

2022-12-19 17:38:04

by Bruno Thomsen

[permalink] [raw]
Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

Den man. 19. dec. 2022 kl. 17.25 skrev Hugo Villeneuve <[email protected]>:
>
> On Mon, 19 Dec 2022 10:14:10 +0100
> Bruno Thomsen <[email protected]> wrote:
>
> > Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <[email protected]>:
> > >
> > > From: Hugo Villeneuve <[email protected]>
> > >
> > > Add support for new NXP RTC PCF2131.
> > >
> > > Signed-off-by: Hugo Villeneuve <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > index cde7b1675ead..a8f8c23da4d8 100644
> > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > @@ -14,7 +14,9 @@ maintainers:
> > >
> > > properties:
> > > compatible:
> > > - const: nxp,pcf2127
> > > + enum:
> > > + - nxp,pcf2127
> > > + - nxp,pcf2131
> >
> > The enum is incomplete as pcf2127_of_match struct also contains:
> > nxp,pcf2129
> > ncp,pca2129
> >
> > /Bruno
>
> Hi,
> if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...
>

Correct, I just noticed while doing review.

> Hugo.
>
>
> > > reg:
> > > maxItems: 1
> > > --
> > > 2.30.2
> > >
> >
>
>
> --
> Hugo Villeneuve <[email protected]>

2022-12-19 19:00:17

by Hugo Villeneuve

[permalink] [raw]
Subject: Re: [PATCH v3 14/14] dt-bindings: rtc: pcf2127: add PCF2131

On Mon, 19 Dec 2022 18:18:58 +0100
Bruno Thomsen <[email protected]> wrote:

> Den man. 19. dec. 2022 kl. 17.25 skrev Hugo Villeneuve <[email protected]>:
> >
> > On Mon, 19 Dec 2022 10:14:10 +0100
> > Bruno Thomsen <[email protected]> wrote:
> >
> > > Den tor. 15. dec. 2022 kl. 16.19 skrev Hugo Villeneuve <[email protected]>:
> > > >
> > > > From: Hugo Villeneuve <[email protected]>
> > > >
> > > > Add support for new NXP RTC PCF2131.
> > > >
> > > > Signed-off-by: Hugo Villeneuve <[email protected]>
> > > > ---
> > > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 4 +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > index cde7b1675ead..a8f8c23da4d8 100644
> > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > > > @@ -14,7 +14,9 @@ maintainers:
> > > >
> > > > properties:
> > > > compatible:
> > > > - const: nxp,pcf2127
> > > > + enum:
> > > > + - nxp,pcf2127
> > > > + - nxp,pcf2131
> > >
> > > The enum is incomplete as pcf2127_of_match struct also contains:
> > > nxp,pcf2129
> > > ncp,pca2129
> > >
> > > /Bruno
> >
> > Hi,
> > if I understand correctly, this means that the pca2129 and pcf2129 entries are already missing and should be added in a fix or a patch outside the scope of my new driver...
> >
>
> Correct, I just noticed while doing review.

Hi,
I will send a separate patch very soon.

Thank you,
Hugo. V.


> > > > reg:
> > > > maxItems: 1
> > > > --
> > > > 2.30.2
> > > >
> > >
> >
> >
> > --
> > Hugo Villeneuve <[email protected]>
>


--
Hugo Villeneuve <[email protected]>