This error code was probably excluded here originally because it never
actually reaches user programs when a syscall returns it. However, from
the perspective of a kernel driver, it is still a perfectly valid error
type, that the driver might need to return. E.g., this can be necessary
when a signal occurs during sleep.
Signed-off-by: Alice Ryhl <[email protected]>
---
rust/kernel/error.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index 5f4114b30b94..cbde1b2d29f4 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -58,6 +58,7 @@ pub mod code {
declare_err!(EPIPE, "Broken pipe.");
declare_err!(EDOM, "Math argument out of domain of func.");
declare_err!(ERANGE, "Math result not representable.");
+ declare_err!(ERESTARTSYS, "Restart the system call.");
}
/// Generic integer kernel error.
base-commit: ea76e08f4d901a450619831a255e9e0a4c0ed162
--
2.40.1.495.gc816e09b53d-goog
On Wed, May 3, 2023 at 10:40 AM Alice Ryhl <[email protected]> wrote:
>
> This error code was probably excluded here originally because it never
> actually reaches user programs when a syscall returns it. However, from
The reason is that commit 266def2a0f5b ("rust: error: add codes from
`errno-base.h`") only introduced the ones from
`include/uapi/asm-generic/errno-base.h`, but not the ones from
`include/linux/errno.h` (or `include/uapi/asm-generic/errno.h`).
Given this is an independent patch, should we introduce the rest too, at once?
Cheers,
Miguel
On 27.04.23 00:57, Roy Matero <[email protected]> wrote:
> Fix sorting of rust/bindings/binding_helper.h's includes,
> to maintain consistency and rust idoms
>
> Suggested-by: Miguel Ojeda <[email protected]>
> Link: https://github.com/Rust-for-Linux/linux/issues/1002
>
> Signed-off-by: Roy Matero <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Seems like I messed up something with this email. It's supposed to be a reply to
https://lore.kernel.org/all/[email protected]/
On Wed, May 3, 2023 at 12:59 PM Alice Ryhl <[email protected]> wrote:
>
> On 27.04.23 00:57, Roy Matero <[email protected]> wrote:
> > Fix sorting of rust/bindings/binding_helper.h's includes,
> > to maintain consistency and rust idoms
> >
> > Suggested-by: Miguel Ojeda <[email protected]>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1002
> >
> > Signed-off-by: Roy Matero <[email protected]>
>
> Reviewed-by: Alice Ryhl <[email protected]>