2015-06-29 20:19:15

by Ravi Teja Darbha

Subject: [PATCH RESEND] rtl8712:Fix checkpatch warning

Fix line over 80 characters warning.

Signed-off-by: Ravi Teja Darbha <[email protected]>
---
drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index fcb8c61..4fa2540 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)

/*init recv_buf*/
_init_queue(&precvpriv->free_recv_buf_queue);
- precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
- GFP_ATOMIC);
+ precvpriv->pallocated_recv_buf =
+ kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);
if (precvpriv->pallocated_recv_buf == NULL)
return _FAIL;
precvpriv->precv_buf = precvpriv->pallocated_recv_buf + 4 -
--
1.9.1

2015-06-29 20:34:03

by Frans Klaver

Subject: Re: [PATCH RESEND] rtl8712:Fix checkpatch warning

On Mon, Jun 29, 2015 at 10:18 PM, Ravi Teja Darbha <[email protected]> wrote:
>
> Fix line over 80 characters warning.
>
> Signed-off-by: Ravi Teja Darbha <[email protected]>
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index fcb8c61..4fa2540 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)
>
> /*init recv_buf*/
> _init_queue(&precvpriv->free_recv_buf_queue);
> - precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
> - GFP_ATOMIC);
> + precvpriv->pallocated_recv_buf =
> + kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);
> if (precvpriv->pallocated_recv_buf == NULL)
> return _FAIL;
> precvpriv->precv_buf = precvpriv->pallocated_recv_buf + 4 -
> --
> 1.9.1

Patch still got messed up. Try using git-send-email instead of
thunderbird. Or fix thunderbird not to mess with tab characters.

Frans

2015-06-29 20:37:51

by Greg Kroah-Hartman

Subject: Re: [PATCH RESEND] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:48:48AM +0530, Ravi Teja Darbha wrote:
>
> Fix line over 80 characters warning.
>
> Signed-off-by: Ravi Teja Darbha <[email protected]>
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index fcb8c61..4fa2540 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)
>
> /*init recv_buf*/
> _init_queue(&precvpriv->free_recv_buf_queue);
> - precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
> - GFP_ATOMIC);
> + precvpriv->pallocated_recv_buf =
> + kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);

Again, your patch is corrupted. Please test this out by emailing it to
yourself first and seeing if it can be applied, instead of sending it
out to the world in a broken format.