2021-04-28 23:07:29

by Yu Liu

[permalink] [raw]
Subject: Re: [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table

Ping for attention, thanks.


On Mon, Apr 19, 2021 at 4:53 PM Yu Liu <[email protected]> wrote:
>
> 0x2B, 0x31 and 0x33 are reserved for future use but were not present in
> the HCI to MGMT conversion table, this caused the conversion to be
> incorrect for the HCI status code greater than 0x2A.
>
> Reviewed-by: Miao-chen Chou <[email protected]>
> Signed-off-by: Yu Liu <[email protected]>
> ---
>
> Changes in v1:
> - Initial change
>
> net/bluetooth/mgmt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 40f75b8e1416..b44e19c69c44 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -252,12 +252,15 @@ static const u8 mgmt_status_table[] = {
> MGMT_STATUS_TIMEOUT, /* Instant Passed */
> MGMT_STATUS_NOT_SUPPORTED, /* Pairing Not Supported */
> MGMT_STATUS_FAILED, /* Transaction Collision */
> + MGMT_STATUS_FAILED, /* Reserved for future use */
> MGMT_STATUS_INVALID_PARAMS, /* Unacceptable Parameter */
> MGMT_STATUS_REJECTED, /* QoS Rejected */
> MGMT_STATUS_NOT_SUPPORTED, /* Classification Not Supported */
> MGMT_STATUS_REJECTED, /* Insufficient Security */
> MGMT_STATUS_INVALID_PARAMS, /* Parameter Out Of Range */
> + MGMT_STATUS_FAILED, /* Reserved for future use */
> MGMT_STATUS_BUSY, /* Role Switch Pending */
> + MGMT_STATUS_FAILED, /* Reserved for future use */
> MGMT_STATUS_FAILED, /* Slot Violation */
> MGMT_STATUS_FAILED, /* Role Switch Failed */
> MGMT_STATUS_INVALID_PARAMS, /* EIR Too Large */
> --
> 2.31.1.368.gbe11c130af-goog
>