2021-01-15 00:14:56

by Davidlohr Bueso

Subject: [PATCH] audit: Remove leftover reference to the audit_tasklet

This was replaced with a kauditd_wait kthread long ago,
back in:

b7d1125817c (AUDIT: Send netlink messages from a separate kernel thread)

Update the stale comment.

Signed-off-by: Davidlohr Bueso <[email protected]>
---
kernel/audit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 1ffc2e059027..8fd735190c12 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -2365,7 +2365,7 @@ int audit_signal_info(int sig, struct task_struct *t)
*
* We can not do a netlink send inside an irq context because it blocks (last
* arg, flags, is not set to MSG_DONTWAIT), so the audit buffer is placed on a
- * queue and a tasklet is scheduled to remove them from the queue outside the
+ * queue and a kthread is scheduled to remove them from the queue outside the
* irq context. May be called in any context.
*/
void audit_log_end(struct audit_buffer *ab)
--
2.26.2

2021-01-15 17:11:27

by Paul Moore

Subject: Re: [PATCH] audit: Remove leftover reference to the audit_tasklet

On Thu, Jan 14, 2021 at 7:12 PM Davidlohr Bueso <[email protected]> wrote:
>
> This was replaced with a kauditd_wait kthread long ago,
> back in:
>
> b7d1125817c (AUDIT: Send netlink messages from a separate kernel thread)
>
> Update the stale comment.
>
> Signed-off-by: Davidlohr Bueso <[email protected]>
> ---
> kernel/audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Nice catch. Merged into audit/next, thanks!

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 1ffc2e059027..8fd735190c12 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -2365,7 +2365,7 @@ int audit_signal_info(int sig, struct task_struct *t)
> *
> * We can not do a netlink send inside an irq context because it blocks (last
> * arg, flags, is not set to MSG_DONTWAIT), so the audit buffer is placed on a
> - * queue and a tasklet is scheduled to remove them from the queue outside the
> + * queue and a kthread is scheduled to remove them from the queue outside the
> * irq context. May be called in any context.
> */
> void audit_log_end(struct audit_buffer *ab)
> --
> 2.26.2

--
paul moore
http://www.paul-moore.com