2023-07-21 03:50:36

by Jiapeng Chong

Subject: [PATCH] selinux: Use NULL for pointers

Replace integer constants with NULL.

security/selinux/hooks.c:251:41: warning: Using plain integer as NULL pointer.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5958
Signed-off-by: Jiapeng Chong <[email protected]>
---
security/selinux/hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 62072b63b19b..d0818a338fa8 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -248,7 +248,7 @@ static void ad_net_init_from_iif(struct common_audit_data *ad,
struct lsm_network_audit *net,
int ifindex, u16 family)
{
- __ad_net_init(ad, net, ifindex, 0, family);
+ __ad_net_init(ad, net, ifindex, NULL, family);
}

/*
--
2.20.1.7.g153144c

2023-07-21 14:38:00

by Paul Moore

Subject: Re: [PATCH] selinux: Use NULL for pointers

On Thu, Jul 20, 2023 at 11:32 PM Jiapeng Chong
<[email protected]> wrote:
>
> Replace integer constants with NULL.
>
> security/selinux/hooks.c:251:41: warning: Using plain integer as NULL pointer.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5958
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thank you for your patch, but a patch to address this problem has
already been posted to the list.

https://lore.kernel.org/selinux/[email protected]/

--
paul-moore.com