2024-02-23 10:16:42

by Kunwu Chan

Subject: [PATCH RESEND] cred: Use KMEM_CACHE instead of kmem_cache_create

From: Kunwu Chan <[email protected]>

commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
introduces a new macro.
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan <[email protected]>
---

Notes:
I'am Kunwu.Chan, the problem(https://lore.kernel.org/all/CAHC9VhTJXfPztz2W_V6sp41PJW8dzvZH0YdnRXd7tUZOF1Q09Q@mail.gmail.com/) may be caused by my email server.
I change the email and send it to myself, the raw email seems ok.
So i resend it.

kernel/cred.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index c033a201c808..02a96e9d9cfd 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -606,8 +606,8 @@ int set_cred_ucounts(struct cred *new)
void __init cred_init(void)
{
/* allocate a slab in which we can store credentials */
- cred_jar = kmem_cache_create("cred_jar", sizeof(struct cred), 0,
- SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL);
+ cred_jar = KMEM_CACHE(cred,
+ SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
}

/**
--
2.39.2

2024-02-23 22:38:46

by Paul Moore

Subject: Re: [PATCH RESEND] cred: Use KMEM_CACHE instead of kmem_cache_create

On Fri, Feb 23, 2024 at 5:16 AM Kunwu Chan <[email protected]> wrote:
>
> From: Kunwu Chan <[email protected]>
>
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <[email protected]>
> ---
>
> Notes:
> I'am Kunwu.Chan, the problem(https://lore.kernel.org/all/CAHC9VhTJXfPztz2W_V6sp41PJW8dzvZH0YdnRXd7tUZOF1Q09Q@mail.gmail.com/) may be caused by my email server.
> I change the email and send it to myself, the raw email seems ok.
> So i resend it.
>
> kernel/cred.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, that worked much better. As the prior patch sat for weeks
without any objections I've gone ahead and merged this via the lsm/dev
tree; if anyone has any objections please let me know before the
upcoming merge window.

> diff --git a/kernel/cred.c b/kernel/cred.c
> index c033a201c808..02a96e9d9cfd 100644
> --- a/kernel/cred.c
> +++ b/kernel/cred.c
> @@ -606,8 +606,8 @@ int set_cred_ucounts(struct cred *new)
> void __init cred_init(void)
> {
> /* allocate a slab in which we can store credentials */
> - cred_jar = kmem_cache_create("cred_jar", sizeof(struct cred), 0,
> - SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL);
> + cred_jar = KMEM_CACHE(cred,
> + SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT);
> }
>
> /**
> --
> 2.39.2

--
paul-moore.com