On Sun, Sep 3, 2023 at 8:05 PM Inki Dae <[email protected]> wrote:
>
> 2023년 8월 29일 (화) 오전 7:38, Adam Ford <[email protected]>님이 작성:
> >
> > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter
> > <[email protected]> wrote:
> > >
> > > From: Marco Felsch <[email protected]>
> > >
> > > Since the MIPI configuration can be changed on demand it is very useful
> > > to print more MIPI settings during the MIPI device attach step.
> > >
> > > Signed-off-by: Marco Felsch <[email protected]>
> > > Signed-off-by: Michael Tretter <[email protected]>
> >
> > Reviewed-by: Adam Ford <[email protected]> #imx8mm-beacon
> > Tested-by: Adam Ford <[email protected]> #imx8mm-beacon
>
> Reviewed-by: Inki Dae <[email protected]>
> Acked-by: Inki Dae <[email protected]>
What needs to be done in order to get this accepted? This series is a
very nice improvement in i.MX8M Mini / Nano.
adam
>
> >
> > > ---
> > > drivers/gpu/drm/bridge/samsung-dsim.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> > > index 73ec60757dbc..6778f1751faa 100644
> > > --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> > > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> > > @@ -1711,7 +1711,10 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host,
> > > return ret;
> > > }
> > >
> > > - DRM_DEV_INFO(dev, "Attached %s device\n", device->name);
> > > + DRM_DEV_INFO(dev, "Attached %s device (lanes:%d bpp:%d mode-flags:0x%lx)\n",
> > > + device->name, device->lanes,
> > > + mipi_dsi_pixel_format_to_bpp(device->format),
> > > + device->mode_flags);
> > >
> > > drm_bridge_add(&dsi->bridge);
> > >
> > >
> > > --
> > > 2.39.2
> > >
On Wed, 27 Sep 2023 07:47:53 -0500, Adam Ford wrote:
> On Sun, Sep 3, 2023 at 8:05 PM Inki Dae <[email protected]> wrote:
> >
> > 2023년 8월 29일 (화) 오전 7:38, Adam Ford <[email protected]>님이 작성:
> > >
> > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter
> > > <[email protected]> wrote:
> > > >
> > > > From: Marco Felsch <[email protected]>
> > > >
> > > > Since the MIPI configuration can be changed on demand it is very useful
> > > > to print more MIPI settings during the MIPI device attach step.
> > > >
> > > > Signed-off-by: Marco Felsch <[email protected]>
> > > > Signed-off-by: Michael Tretter <[email protected]>
> > >
> > > Reviewed-by: Adam Ford <[email protected]> #imx8mm-beacon
> > > Tested-by: Adam Ford <[email protected]> #imx8mm-beacon
> >
> > Reviewed-by: Inki Dae <[email protected]>
> > Acked-by: Inki Dae <[email protected]>
>
> What needs to be done in order to get this accepted? This series is a
> very nice improvement in i.MX8M Mini / Nano.
I think it is my turn to send a v2 that addresses the review comments. I'll
try to find time this week.
Michael
>
> adam
> >
> > >
> > > > ---
> > > > drivers/gpu/drm/bridge/samsung-dsim.c | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> > > > index 73ec60757dbc..6778f1751faa 100644
> > > > --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> > > > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> > > > @@ -1711,7 +1711,10 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host,
> > > > return ret;
> > > > }
> > > >
> > > > - DRM_DEV_INFO(dev, "Attached %s device\n", device->name);
> > > > + DRM_DEV_INFO(dev, "Attached %s device (lanes:%d bpp:%d mode-flags:0x%lx)\n",
> > > > + device->name, device->lanes,
> > > > + mipi_dsi_pixel_format_to_bpp(device->format),
> > > > + device->mode_flags);
> > > >
> > > > drm_bridge_add(&dsi->bridge);
> > > >
> > > >
> > > > --
> > > > 2.39.2
> > > >
>