2012-06-14 12:39:46

by Wanpeng Li

Subject: [PATCH] mm: fix page reclaim comment error

From: Wanpeng Li <[email protected]>

From: Wanpeng Li <[email protected]>

Since there are five lists in LRU cache, the array nr in get_scan_count
should be:

nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
nr[2] = file inactive pages to scan; nr[3] = file active pages to scan

Signed-off-by: Wanpeng Li <[email protected]>
---
mm/vmscan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eeb3bc9..ed823df 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1567,7 +1567,8 @@ static int vmscan_swappiness(struct scan_control *sc)
* by looking at the fraction of the pages scanned we did rotate back
* onto the active list instead of evict.
*
- * nr[0] = anon pages to scan; nr[1] = file pages to scan
+ * nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
+ * nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
*/
static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
unsigned long *nr)
--
1.7.9.5

2012-06-14 15:21:08

by KOSAKI Motohiro

Subject: Re: [PATCH] mm: fix page reclaim comment error

On Thu, Jun 14, 2012 at 8:38 AM, [A <[email protected]> wrote:
> From: Wanpeng Li <[email protected]>
>
> From: Wanpeng Li <[email protected]>
>
> Since there are five lists in LRU cache, the array nr in get_scan_count
> should be:
>
> nr[0] = anon inactive pages to scan; nr[1] = anon active pages to scan
> nr[2] = file inactive pages to scan; nr[3] = file active pages to scan
>
> Signed-off-by: Wanpeng Li <[email protected]>

Acked-by: KOSAKI Motohiro <[email protected]>