2022-11-04 16:43:17

by Rob Herring

Subject: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

The examples' cache nodes are incomplete as 'cache-unified' and
'cache-level' are required cache properties.

Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/thermal/thermal-cooling-devices.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
index 850a9841b110..7bb9327caa13 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
@@ -76,9 +76,13 @@ examples:
next-level-cache = <&L2_0>;
L2_0: l2-cache {
compatible = "cache";
+ cache-unified;
+ cache-level = <2>;
next-level-cache = <&L3_0>;
L3_0: l3-cache {
compatible = "cache";
+ cache-unified;
+ cache-level = <3>;
};
};
};
--
2.35.1

2022-11-06 11:14:58

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

On 04/11/2022 17:24, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
>
> Signed-off-by: Rob Herring <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-11-06 19:10:30

by Amit Kucheria

Subject: Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

On Fri, Nov 4, 2022 at 9:55 PM Rob Herring <[email protected]> wrote:
>
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Amit Kucheria <[email protected]>

> ---
> .../devicetree/bindings/thermal/thermal-cooling-devices.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> index 850a9841b110..7bb9327caa13 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> @@ -76,9 +76,13 @@ examples:
> next-level-cache = <&L2_0>;
> L2_0: l2-cache {
> compatible = "cache";
> + cache-unified;
> + cache-level = <2>;
> next-level-cache = <&L3_0>;
> L3_0: l3-cache {
> compatible = "cache";
> + cache-unified;
> + cache-level = <3>;
> };
> };
> };
> --
> 2.35.1
>

2022-12-06 02:22:40

by Rob Herring

Subject: Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties

On Fri, 04 Nov 2022 11:24:50 -0500, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/thermal/thermal-cooling-devices.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

Applied, thanks!