2020-04-02 14:28:49

by Daniel Lezcano

Subject: [PATCH V2 8/9] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device

All callers of the functions depends on THERMAL, it is pointless to
define stubs. Remove them.

Signed-off-by: Daniel Lezcano <[email protected]>
---
include/linux/thermal.h | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 12df9ff0182d..7b3dbfe15b59 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -426,16 +426,6 @@ static inline struct thermal_zone_device *thermal_zone_device_register(
static inline void thermal_zone_device_unregister(
struct thermal_zone_device *tz)
{ }
-static inline int thermal_zone_bind_cooling_device(
- struct thermal_zone_device *tz, int trip,
- struct thermal_cooling_device *cdev,
- unsigned long upper, unsigned long lower,
- unsigned int weight)
-{ return -ENODEV; }
-static inline int thermal_zone_unbind_cooling_device(
- struct thermal_zone_device *tz, int trip,
- struct thermal_cooling_device *cdev)
-{ return -ENODEV; }
static inline void thermal_zone_device_update(struct thermal_zone_device *tz,
enum thermal_notify_event event)
{ }
--
2.17.1

2020-04-04 07:32:48

by Amit Kucheria

Subject: Re: [PATCH V2 8/9] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device

On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <[email protected]> wrote:
>
> All callers of the functions depends on THERMAL, it is pointless to
> define stubs. Remove them.
>
> Signed-off-by: Daniel Lezcano <[email protected]>

Reviewed-by: Amit Kucheria <[email protected]>

> ---
> include/linux/thermal.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 12df9ff0182d..7b3dbfe15b59 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -426,16 +426,6 @@ static inline struct thermal_zone_device *thermal_zone_device_register(
> static inline void thermal_zone_device_unregister(
> struct thermal_zone_device *tz)
> { }
> -static inline int thermal_zone_bind_cooling_device(
> - struct thermal_zone_device *tz, int trip,
> - struct thermal_cooling_device *cdev,
> - unsigned long upper, unsigned long lower,
> - unsigned int weight)
> -{ return -ENODEV; }
> -static inline int thermal_zone_unbind_cooling_device(
> - struct thermal_zone_device *tz, int trip,
> - struct thermal_cooling_device *cdev)
> -{ return -ENODEV; }
> static inline void thermal_zone_device_update(struct thermal_zone_device *tz,
> enum thermal_notify_event event)
> { }
> --
> 2.17.1
>