2020-03-19 08:35:23

by Anson Huang

Subject: [PATCH] thermal: imx_sc_thermal: Fix incorrect data type

The temperature value passed from SCU could be negative value,
the data type should be signed instead of unsigned.

Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: Anson Huang <[email protected]>
---
drivers/thermal/imx_sc_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index dbb277a..a8723b1 100644
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -30,8 +30,8 @@ struct req_get_temp {
} __packed __aligned(4);

struct resp_get_temp {
- u16 celsius;
- u8 tenths;
+ s16 celsius;
+ s8 tenths;
} __packed __aligned(4);

struct imx_sc_msg_misc_get_temp {
--
2.7.4

2020-03-19 08:55:31

by Amit Kucheria

Subject: Re: [PATCH] thermal: imx_sc_thermal: Fix incorrect data type

On Thu, Mar 19, 2020 at 2:03 PM Anson Huang <[email protected]> wrote:
>
> The temperature value passed from SCU could be negative value,
> the data type should be signed instead of unsigned.
>
> Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support")
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Amit Kucheria <[email protected]>

> ---
> drivers/thermal/imx_sc_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index dbb277a..a8723b1 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -30,8 +30,8 @@ struct req_get_temp {
> } __packed __aligned(4);
>
> struct resp_get_temp {
> - u16 celsius;
> - u8 tenths;
> + s16 celsius;
> + s8 tenths;
> } __packed __aligned(4);
>
> struct imx_sc_msg_misc_get_temp {
> --
> 2.7.4
>

2020-03-19 11:57:28

by Daniel Lezcano

Subject: Re: [PATCH] thermal: imx_sc_thermal: Fix incorrect data type

On 19/03/2020 09:26, Anson Huang wrote:
> The temperature value passed from SCU could be negative value,
> the data type should be signed instead of unsigned.
>
> Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support")
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks

> ---
> drivers/thermal/imx_sc_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index dbb277a..a8723b1 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -30,8 +30,8 @@ struct req_get_temp {
> } __packed __aligned(4);
>
> struct resp_get_temp {
> - u16 celsius;
> - u8 tenths;
> + s16 celsius;
> + s8 tenths;
> } __packed __aligned(4);
>
> struct imx_sc_msg_misc_get_temp {
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog