2019-09-12 01:34:19

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 00/12] QorIQ TMU multi-sensor and HWMON support

Everyone:

This series contains patches adding support for HWMON integration, bug
fixes and general improvements (hopefully) for TMU driver I made while
working on it on i.MX8MQ.

Feedback is welcome!

Thanks,
Andrey Smirnov

Changes since [v6]:

- Rebased on top of Zhang's "next" branch

- Added "thermal: qoriq: Drop unnecessary drvdata cleanup"

Changes since [v5]

- Rebased on recent linux-next, dropped "thermal: qoriq: Remove
unnecessary DT node is NULL check" since it is already in the
tree

- Dropped dependency on [rfc]

Changes since [v4]

- Collected Tested-by from Lucas

- Collected Reviewed-by from Daniel

- Converted "thermal: qoriq: Enable all sensors before registering
them" to use if instead of switch statement for error checking

Changes since [v3]

- Series reabse on top of [rfc]

- Fixed incorrect goto label in "thermal: qoriq: Pass data to
qoriq_tmu_calibration()"

- Added REGS_TRITSR() register description to "thermal: qoriq: Do
not report invalid temperature reading"

- Reworded commit message of "thermal: qoriq: Remove unnecessary
DT node is NULL check"

Changes since [v2]

- Patches rebased on v5.1-rc1

Changes since [v1]

- Rebased on "linus" branch of
git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git
that included latest chagnes adding multi-sensors support

- Dropped

thermal: qoriq: Add support for multiple thremal sites
thermal: qoriq: Be more strict when parsing
thermal: qoriq: Simplify error handling in qoriq_tmu_get_sensor_id()

since they are no longer relevant

- Added

thermal: qoriq: Don't store struct thermal_zone_device reference
thermal: qoriq: Add local struct qoriq_sensor pointer
thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data
thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly

to simplify latest codebase

- Changed "thermal: qoriq: Do not report invalid temperature
reading" to use regmap_read_poll_timeout() to make sure that
tmu_get_temp() waits for fist sample to be ready before
reporting it. This case is triggered on my setup if
qoriq_thermal is compiled as a module

[v1] lore.kernel.org/lkml/[email protected]
[v2] lore.kernel.org/lkml/[email protected]
[v3] lore.kernel.org/lkml/[email protected]
[v4] lore.kernel.org/lkml/[email protected]
[v5] lore.kernel.org/lkml/[email protected]
[v6] lore.kernel.org/lkml/[email protected]
[rfc] lore.kernel.org/lkml/[email protected]

Andrey Smirnov (12):
thermal: qoriq: Add local struct device pointer
thermal: qoriq: Don't store struct thermal_zone_device reference
thermal: qoriq: Add local struct qoriq_sensor pointer
thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data
thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly
thermal: qoriq: Pass data to qoriq_tmu_calibration() directly
thermal: qoriq: Drop unnecessary drvdata cleanup
thermal: qoriq: Convert driver to use regmap API
thermal: qoriq: Enable all sensors before registering them
thermal: qoriq: Do not report invalid temperature reading
thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs()
thermal: qoriq: Add hwmon support

drivers/thermal/qoriq_thermal.c | 252 +++++++++++++++++---------------
drivers/thermal/thermal_hwmon.c | 28 ++++
drivers/thermal/thermal_hwmon.h | 7 +
3 files changed, 167 insertions(+), 120 deletions(-)

--
2.21.0


2019-09-12 01:35:18

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 04/12] thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data

Embed per-sensor data into struct qoriq_tmu_data so we can drop the
code allocating it. This also allows us to get rid of per-sensor back
reference to struct qoriq_tmu_data since now its address can be
calculated using container_of().

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Zhang Rui <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Angus Ainslie (Purism) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/thermal/qoriq_thermal.c | 23 ++++++++---------------
1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index ae22836c471d..f8f5228d83af 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -60,13 +60,10 @@ struct qoriq_tmu_regs {
u32 ttr3cr; /* Temperature Range 3 Control Register */
};

-struct qoriq_tmu_data;
-
/*
* Thermal zone data
*/
struct qoriq_sensor {
- struct qoriq_tmu_data *qdata;
int id;
};

@@ -74,9 +71,14 @@ struct qoriq_tmu_data {
struct qoriq_tmu_regs __iomem *regs;
struct clk *clk;
bool little_endian;
- struct qoriq_sensor *sensor[SITES_MAX];
+ struct qoriq_sensor sensor[SITES_MAX];
};

+static struct qoriq_tmu_data *qoriq_sensor_to_data(struct qoriq_sensor *s)
+{
+ return container_of(s, struct qoriq_tmu_data, sensor[s->id]);
+}
+
static void tmu_write(struct qoriq_tmu_data *p, u32 val, void __iomem *addr)
{
if (p->little_endian)
@@ -96,7 +98,7 @@ static u32 tmu_read(struct qoriq_tmu_data *p, void __iomem *addr)
static int tmu_get_temp(void *p, int *temp)
{
struct qoriq_sensor *qsensor = p;
- struct qoriq_tmu_data *qdata = qsensor->qdata;
+ struct qoriq_tmu_data *qdata = qoriq_sensor_to_data(qsensor);
u32 val;

val = tmu_read(qdata, &qdata->regs->site[qsensor->id].tritsr);
@@ -116,19 +118,10 @@ static int qoriq_tmu_register_tmu_zone(struct platform_device *pdev)

for (id = 0; id < SITES_MAX; id++) {
struct thermal_zone_device *tzd;
- struct qoriq_sensor *sensor;
+ struct qoriq_sensor *sensor = &qdata->sensor[id];
int ret;

- sensor = devm_kzalloc(&pdev->dev,
- sizeof(struct qoriq_sensor),
- GFP_KERNEL);
- if (!qdata->sensor[id])
- return -ENOMEM;
-
- qdata->sensor[id] = sensor;
-
sensor->id = id;
- sensor->qdata = qdata;

tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, id,
sensor,
--
2.21.0

2019-09-12 01:35:38

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 01/12] thermal: qoriq: Add local struct device pointer

Use a local "struct device *dev" for brevity. No functional change
intended.

Signed-off-by: Andrey Smirnov <[email protected]>
Acked-by: Daniel Lezcano <[email protected]>
Tested-by: Lucas Stach <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Angus Ainslie (Purism) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/thermal/qoriq_thermal.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index 39542c670301..5df6267a5da0 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -194,8 +194,9 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
int ret;
struct qoriq_tmu_data *data;
struct device_node *np = pdev->dev.of_node;
+ struct device *dev = &pdev->dev;

- data = devm_kzalloc(&pdev->dev, sizeof(struct qoriq_tmu_data),
+ data = devm_kzalloc(dev, sizeof(struct qoriq_tmu_data),
GFP_KERNEL);
if (!data)
return -ENOMEM;
@@ -206,17 +207,17 @@ static int qoriq_tmu_probe(struct platform_device *pdev)

data->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(data->regs)) {
- dev_err(&pdev->dev, "Failed to get memory region\n");
+ dev_err(dev, "Failed to get memory region\n");
return PTR_ERR(data->regs);
}

- data->clk = devm_clk_get_optional(&pdev->dev, NULL);
+ data->clk = devm_clk_get_optional(dev, NULL);
if (IS_ERR(data->clk))
return PTR_ERR(data->clk);

ret = clk_prepare_enable(data->clk);
if (ret) {
- dev_err(&pdev->dev, "Failed to enable clock\n");
+ dev_err(dev, "Failed to enable clock\n");
return ret;
}

@@ -228,7 +229,7 @@ static int qoriq_tmu_probe(struct platform_device *pdev)

ret = qoriq_tmu_register_tmu_zone(pdev);
if (ret < 0) {
- dev_err(&pdev->dev, "Failed to register sensors\n");
+ dev_err(dev, "Failed to register sensors\n");
ret = -ENODEV;
goto err;
}
--
2.21.0

2019-09-12 02:01:50

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 06/12] thermal: qoriq: Pass data to qoriq_tmu_calibration() directly

We can simplify error cleanup code if instead of passing a "struct
platform_device *" to qoriq_tmu_calibration() and deriving a bunch of
pointers from it, we pass those pointers directly. This way we won't
be force to call platform_set_drvdata() as early in qoriq_tmu_probe()
and need to have "platform_set_drvdata(pdev, NULL);" in error path.

Signed-off-by: Andrey Smirnov <[email protected]>
Reviewed-by: Daniel Lezcano <[email protected]>
Tested-by: Lucas Stach <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Angus Ainslie (Purism) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/thermal/qoriq_thermal.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index 5b9f2a31d275..af596c3342d0 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -144,16 +144,16 @@ static int qoriq_tmu_register_tmu_zone(struct device *dev,
return 0;
}

-static int qoriq_tmu_calibration(struct platform_device *pdev)
+static int qoriq_tmu_calibration(struct device *dev,
+ struct qoriq_tmu_data *data)
{
int i, val, len;
u32 range[4];
const u32 *calibration;
- struct device_node *np = pdev->dev.of_node;
- struct qoriq_tmu_data *data = platform_get_drvdata(pdev);
+ struct device_node *np = dev->of_node;

if (of_property_read_u32_array(np, "fsl,tmu-range", range, 4)) {
- dev_err(&pdev->dev, "missing calibration range.\n");
+ dev_err(dev, "missing calibration range.\n");
return -ENODEV;
}

@@ -165,7 +165,7 @@ static int qoriq_tmu_calibration(struct platform_device *pdev)

calibration = of_get_property(np, "fsl,tmu-calibration", &len);
if (calibration == NULL || len % 8) {
- dev_err(&pdev->dev, "invalid calibration data.\n");
+ dev_err(dev, "invalid calibration data.\n");
return -ENODEV;
}

@@ -203,8 +203,6 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
if (!data)
return -ENOMEM;

- platform_set_drvdata(pdev, data);
-
data->little_endian = of_property_read_bool(np, "little-endian");

data->regs = devm_platform_ioremap_resource(pdev, 0);
@@ -225,7 +223,7 @@ static int qoriq_tmu_probe(struct platform_device *pdev)

qoriq_tmu_init_device(data); /* TMU initialization */

- ret = qoriq_tmu_calibration(pdev); /* TMU calibration */
+ ret = qoriq_tmu_calibration(dev, data); /* TMU calibration */
if (ret < 0)
goto err;

@@ -236,11 +234,12 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
goto err;
}

+ platform_set_drvdata(pdev, data);
+
return 0;

err:
clk_disable_unprepare(data->clk);
- platform_set_drvdata(pdev, NULL);

return ret;
}
--
2.21.0

2019-09-12 02:03:01

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 07/12] thermal: qoriq: Drop unnecessary drvdata cleanup

Driver data of underlying struct device will be set to NULL by Linux's
driver infrastructure. Clearing it here is unnecessary.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Angus Ainslie (Purism) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/thermal/qoriq_thermal.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index af596c3342d0..8a28a4433d44 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -253,8 +253,6 @@ static int qoriq_tmu_remove(struct platform_device *pdev)

clk_disable_unprepare(data->clk);

- platform_set_drvdata(pdev, NULL);
-
return 0;
}

--
2.21.0

2019-09-12 02:09:03

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 09/12] thermal: qoriq: Enable all sensors before registering them

Tmu_get_temp will get called as a part of sensor registration via
devm_thermal_zone_of_sensor_register(). To prevent it from retruning
bogus data we need to enable sensor monitoring before that. Looking at
the datasheet (i.MX8MQ RM) there doesn't seem to be any harm in
enabling them all, so, for the sake of simplicity, change the code to
do just that.

Signed-off-by: Andrey Smirnov <[email protected]>
Tested-by: Lucas Stach <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Angus Ainslie (Purism) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/thermal/qoriq_thermal.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index 32bf5ed57f5c..1cc53a4a5c47 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -24,6 +24,7 @@
#define TMR_DISABLE 0x0
#define TMR_ME 0x80000000
#define TMR_ALPF 0x0c000000
+#define TMR_MSITE_ALL GENMASK(15, 0)

#define REGS_TMTMIR 0x008 /* Temperature measurement interval Register */
#define TMTMIR_DEFAULT 0x0000000f
@@ -77,7 +78,10 @@ static const struct thermal_zone_of_device_ops tmu_tz_ops = {
static int qoriq_tmu_register_tmu_zone(struct device *dev,
struct qoriq_tmu_data *qdata)
{
- int id, sites = 0;
+ int id;
+
+ regmap_write(qdata->regmap, REGS_TMR,
+ TMR_MSITE_ALL | TMR_ME | TMR_ALPF);

for (id = 0; id < SITES_MAX; id++) {
struct thermal_zone_device *tzd;
@@ -93,18 +97,12 @@ static int qoriq_tmu_register_tmu_zone(struct device *dev,
if (ret) {
if (ret == -ENODEV)
continue;
- else
- return ret;
- }

- sites |= 0x1 << (15 - id);
+ regmap_write(qdata->regmap, REGS_TMR, TMR_DISABLE);
+ return ret;
+ }
}

- /* Enable monitoring */
- if (sites != 0)
- regmap_write(qdata->regmap, REGS_TMR,
- sites | TMR_ME | TMR_ALPF);
-
return 0;
}

--
2.21.0

2019-09-12 02:40:18

by Andrey Smirnov

[permalink] [raw]
Subject: [PATCH v7 05/12] thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly

Pass all necessary data to qoriq_tmu_register_tmu_zone() directly
instead of passing a platform device and then deriving it. This is
done as a first step to simplify resource deallocation code.

Signed-off-by: Andrey Smirnov <[email protected]>
Acked-by: Daniel Lezcano <[email protected]>
Tested-by: Lucas Stach <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Eduardo Valentin <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Angus Ainslie (Purism) <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/thermal/qoriq_thermal.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index f8f5228d83af..5b9f2a31d275 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -111,9 +111,9 @@ static const struct thermal_zone_of_device_ops tmu_tz_ops = {
.get_temp = tmu_get_temp,
};

-static int qoriq_tmu_register_tmu_zone(struct platform_device *pdev)
+static int qoriq_tmu_register_tmu_zone(struct device *dev,
+ struct qoriq_tmu_data *qdata)
{
- struct qoriq_tmu_data *qdata = platform_get_drvdata(pdev);
int id, sites = 0;

for (id = 0; id < SITES_MAX; id++) {
@@ -123,7 +123,7 @@ static int qoriq_tmu_register_tmu_zone(struct platform_device *pdev)

sensor->id = id;

- tzd = devm_thermal_zone_of_sensor_register(&pdev->dev, id,
+ tzd = devm_thermal_zone_of_sensor_register(dev, id,
sensor,
&tmu_tz_ops);
ret = PTR_ERR_OR_ZERO(tzd);
@@ -229,7 +229,7 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
if (ret < 0)
goto err;

- ret = qoriq_tmu_register_tmu_zone(pdev);
+ ret = qoriq_tmu_register_tmu_zone(dev, data);
if (ret < 0) {
dev_err(dev, "Failed to register sensors\n");
ret = -ENODEV;
--
2.21.0

2019-12-06 11:48:03

by Lucas Stach

[permalink] [raw]
Subject: Re: [PATCH v7 00/12] QorIQ TMU multi-sensor and HWMON support

Hi all,

can this series be considered for mainline inclusion? It has been
tested and works well in our i.MX8M kernel setup.

Regards,
Lucas

On Mi, 2019-09-11 at 18:29 -0700, Andrey Smirnov wrote:
> Everyone:
>
> This series contains patches adding support for HWMON integration, bug
> fixes and general improvements (hopefully) for TMU driver I made while
> working on it on i.MX8MQ.
>
> Feedback is welcome!
>
> Thanks,
> Andrey Smirnov
>
> Changes since [v6]:
>
> - Rebased on top of Zhang's "next" branch
>
> - Added "thermal: qoriq: Drop unnecessary drvdata cleanup"
>
> Changes since [v5]
>
> - Rebased on recent linux-next, dropped "thermal: qoriq: Remove
> unnecessary DT node is NULL check" since it is already in the
> tree
>
> - Dropped dependency on [rfc]
>
> Changes since [v4]
>
> - Collected Tested-by from Lucas
>
> - Collected Reviewed-by from Daniel
>
> - Converted "thermal: qoriq: Enable all sensors before registering
> them" to use if instead of switch statement for error checking
>
> Changes since [v3]
>
> - Series reabse on top of [rfc]
>
> - Fixed incorrect goto label in "thermal: qoriq: Pass data to
> qoriq_tmu_calibration()"
>
> - Added REGS_TRITSR() register description to "thermal: qoriq: Do
> not report invalid temperature reading"
>
> - Reworded commit message of "thermal: qoriq: Remove unnecessary
> DT node is NULL check"
>
> Changes since [v2]
>
> - Patches rebased on v5.1-rc1
>
> Changes since [v1]
>
> - Rebased on "linus" branch of
> git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git
> that included latest chagnes adding multi-sensors support
>
> - Dropped
>
> thermal: qoriq: Add support for multiple thremal sites
> thermal: qoriq: Be more strict when parsing
> thermal: qoriq: Simplify error handling in qoriq_tmu_get_sensor_id()
>
> since they are no longer relevant
>
> - Added
>
> thermal: qoriq: Don't store struct thermal_zone_device reference
> thermal: qoriq: Add local struct qoriq_sensor pointer
> thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data
> thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly
>
> to simplify latest codebase
>
> - Changed "thermal: qoriq: Do not report invalid temperature
> reading" to use regmap_read_poll_timeout() to make sure that
> tmu_get_temp() waits for fist sample to be ready before
> reporting it. This case is triggered on my setup if
> qoriq_thermal is compiled as a module
>
> [v1] lore.kernel.org/lkml/[email protected]
> [v2] lore.kernel.org/lkml/[email protected]
> [v3] lore.kernel.org/lkml/[email protected]
> [v4] lore.kernel.org/lkml/[email protected]
> [v5] lore.kernel.org/lkml/[email protected]
> [v6] lore.kernel.org/lkml/[email protected]
> [rfc] lore.kernel.org/lkml/[email protected]
>
> Andrey Smirnov (12):
> thermal: qoriq: Add local struct device pointer
> thermal: qoriq: Don't store struct thermal_zone_device reference
> thermal: qoriq: Add local struct qoriq_sensor pointer
> thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data
> thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly
> thermal: qoriq: Pass data to qoriq_tmu_calibration() directly
> thermal: qoriq: Drop unnecessary drvdata cleanup
> thermal: qoriq: Convert driver to use regmap API
> thermal: qoriq: Enable all sensors before registering them
> thermal: qoriq: Do not report invalid temperature reading
> thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs()
> thermal: qoriq: Add hwmon support
>
> drivers/thermal/qoriq_thermal.c | 252 +++++++++++++++++---------------
> drivers/thermal/thermal_hwmon.c | 28 ++++
> drivers/thermal/thermal_hwmon.h | 7 +
> 3 files changed, 167 insertions(+), 120 deletions(-)
>

2019-12-06 12:03:44

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH v7 00/12] QorIQ TMU multi-sensor and HWMON support


Hi Luca,

On 06/12/2019 12:46, Lucas Stach wrote:
> Hi all,
>
> can this series be considered for mainline inclusion? It has been
> tested and works well in our i.MX8M kernel setup.

thanks for the reminder. I'll take care of it soon.


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2019-12-09 18:22:43

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH v7 00/12] QorIQ TMU multi-sensor and HWMON support

Hi Lucas,


On 06/12/2019 12:46, Lucas Stach wrote:
> Hi all,
>
> can this series be considered for mainline inclusion? It has been
> tested and works well in our i.MX8M kernel setup.

I'm fine with the changes but the series does not longer apply. I tried
to solve the conflicts but got too many of them.

Is it possible to respin the series?




--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2019-12-09 18:51:23

by Andrey Smirnov

[permalink] [raw]
Subject: Re: [PATCH v7 00/12] QorIQ TMU multi-sensor and HWMON support

On Mon, Dec 9, 2019 at 10:20 AM Daniel Lezcano
<[email protected]> wrote:
>
> Hi Lucas,
>
>
> On 06/12/2019 12:46, Lucas Stach wrote:
> > Hi all,
> >
> > can this series be considered for mainline inclusion? It has been
> > tested and works well in our i.MX8M kernel setup.
>
> I'm fine with the changes but the series does not longer apply. I tried
> to solve the conflicts but got too many of them.
>
> Is it possible to respin the series?
>

Yeah, no problem. Will do.

Thanks,
Andrey Smirnov

2019-12-09 18:55:39

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH v7 00/12] QorIQ TMU multi-sensor and HWMON support

On 09/12/2019 19:49, Andrey Smirnov wrote:
> On Mon, Dec 9, 2019 at 10:20 AM Daniel Lezcano
> <[email protected]> wrote:
>>
>> Hi Lucas,
>>
>>
>> On 06/12/2019 12:46, Lucas Stach wrote:
>>> Hi all,
>>>
>>> can this series be considered for mainline inclusion? It has been
>>> tested and works well in our i.MX8M kernel setup.
>>
>> I'm fine with the changes but the series does not longer apply. I tried
>> to solve the conflicts but got too many of them.
>>
>> Is it possible to respin the series?
>>
>
> Yeah, no problem. Will do.

Thanks and sorry for the delay.



--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog