2014-07-11 13:44:59

by Thomas Gleixner

Subject: [patch 38/55] fs: lockd: Use ktime_get_ns()

Replace the ever recurring:
ts = ktime_get_ts();
ns = timespec_to_ns(&ts);
with
ns = ktime_get_ns();

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Trond Myklebust <[email protected]>
---
fs/lockd/mon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Index: tip/fs/lockd/mon.c
===================================================================
--- tip.orig/fs/lockd/mon.c
+++ tip/fs/lockd/mon.c
@@ -306,11 +306,9 @@ static struct nsm_handle *nsm_lookup_pri
static void nsm_init_private(struct nsm_handle *nsm)
{
u64 *p = (u64 *)&nsm->sm_priv.data;
- struct timespec ts;
s64 ns;

- ktime_get_ts(&ts);
- ns = timespec_to_ns(&ts);
+ ns = ktime_get_ns();
put_unaligned(ns, p);
put_unaligned((unsigned long)nsm, p + 1);
}

2014-07-11 14:04:09

by Trond Myklebust

Subject: Re: [patch 38/55] fs: lockd: Use ktime_get_ns()

On Fri, Jul 11, 2014 at 9:44 AM, Thomas Gleixner <[email protected]> wrote:
> Replace the ever recurring:
> ts = ktime_get_ts();
> ns = timespec_to_ns(&ts);
> with
> ns = ktime_get_ns();
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: "J. Bruce Fields" <[email protected]>
> Cc: Trond Myklebust <[email protected]>
> ---
> fs/lockd/mon.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: tip/fs/lockd/mon.c
> ===================================================================
> --- tip.orig/fs/lockd/mon.c
> +++ tip/fs/lockd/mon.c
> @@ -306,11 +306,9 @@ static struct nsm_handle *nsm_lookup_pri
> static void nsm_init_private(struct nsm_handle *nsm)
> {
> u64 *p = (u64 *)&nsm->sm_priv.data;
> - struct timespec ts;
> s64 ns;
>
> - ktime_get_ts(&ts);
> - ns = timespec_to_ns(&ts);
> + ns = ktime_get_ns();
> put_unaligned(ns, p);
> put_unaligned((unsigned long)nsm, p + 1);
> }
>
>

Looks fine to me.

Acked-by: Trond Myklebust <[email protected]>


--
Trond Myklebust

Linux NFS client maintainer, PrimaryData

[email protected]