2021-04-14 18:24:53

by Lee Jones

Subject: [PATCH 02/57] staging: android: ashmem: Supply description for 'new_range'

Fixes the following W=1 kernel build warning(s):

drivers/staging/android/ashmem.c:189: warning: Function parameter or member 'new_range' not described in 'range_alloc'

Cc: Greg Kroah-Hartman <[email protected]>
Cc: "Arve Hjønnevåg" <[email protected]>
Cc: Todd Kjos <[email protected]>
Cc: Martijn Coenen <[email protected]>
Cc: Joel Fernandes <[email protected]>
Cc: Christian Brauner <[email protected]>
Cc: Hridya Valsaraju <[email protected]>
Cc: Suren Baghdasaryan <[email protected]>
Cc: Robert Love <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/staging/android/ashmem.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273a..8ee4320a5dc6d 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -179,6 +179,7 @@ static inline void lru_del(struct ashmem_range *range)
* @purged: Initial purge status (ASMEM_NOT_PURGED or ASHMEM_WAS_PURGED)
* @start: The starting page (inclusive)
* @end: The ending page (inclusive)
+ * @new_range: The placeholder for the new range
*
* This function is protected by ashmem_mutex.
*/
--
2.27.0

2021-04-15 16:33:17

by Todd Kjos

Subject: Re: [PATCH 02/57] staging: android: ashmem: Supply description for 'new_range'

On Wed, Apr 14, 2021 at 11:11 AM Lee Jones <[email protected]> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/staging/android/ashmem.c:189: warning: Function parameter or member 'new_range' not described in 'range_alloc'
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: "Arve Hjønnevåg" <[email protected]>
> Cc: Todd Kjos <[email protected]>
> Cc: Martijn Coenen <[email protected]>
> Cc: Joel Fernandes <[email protected]>
> Cc: Christian Brauner <[email protected]>
> Cc: Hridya Valsaraju <[email protected]>
> Cc: Suren Baghdasaryan <[email protected]>
> Cc: Robert Love <[email protected]>
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>

Acked-by: Todd Kjos <[email protected]>

> ---
> drivers/staging/android/ashmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index d66a64e42273a..8ee4320a5dc6d 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -179,6 +179,7 @@ static inline void lru_del(struct ashmem_range *range)
> * @purged: Initial purge status (ASMEM_NOT_PURGED or ASHMEM_WAS_PURGED)
> * @start: The starting page (inclusive)
> * @end: The ending page (inclusive)
> + * @new_range: The placeholder for the new range
> *
> * This function is protected by ashmem_mutex.
> */
> --
> 2.27.0
>