2022-07-28 12:25:18

by Miaohe Lin

Subject: [PATCH 3/6] hugetlb_cgroup: hugetlbfs: use helper macro SZ_1{K,M,G}

Use helper macro SZ_1K, SZ_1M and SZ_1G to do the size conversion. Minor
readability improvement.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/hugetlb_cgroup.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
index 99e9a367e1e5..7e0bca52c40f 100644
--- a/mm/hugetlb_cgroup.c
+++ b/mm/hugetlb_cgroup.c
@@ -674,12 +674,12 @@ static ssize_t hugetlb_cgroup_reset(struct kernfs_open_file *of,

static char *mem_fmt(char *buf, int size, unsigned long hsize)
{
- if (hsize >= (1UL << 30))
- snprintf(buf, size, "%luGB", hsize >> 30);
- else if (hsize >= (1UL << 20))
- snprintf(buf, size, "%luMB", hsize >> 20);
+ if (hsize >= SZ_1G)
+ snprintf(buf, size, "%luGB", hsize / SZ_1G);
+ else if (hsize >= SZ_1M)
+ snprintf(buf, size, "%luMB", hsize / SZ_1M);
else
- snprintf(buf, size, "%luKB", hsize >> 10);
+ snprintf(buf, size, "%luKB", hsize / SZ_1K);
return buf;
}

--
2.23.0

2022-07-28 18:22:48

by Mina Almasry

Subject: Re: [PATCH 3/6] hugetlb_cgroup: hugetlbfs: use helper macro SZ_1{K,M,G}

On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <[email protected]> wrote:
>
> Use helper macro SZ_1K, SZ_1M and SZ_1G to do the size conversion. Minor
> readability improvement.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Thanks Miaohe,

Reviewed-by: Mina Almasry <[email protected]>

> ---
> mm/hugetlb_cgroup.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index 99e9a367e1e5..7e0bca52c40f 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -674,12 +674,12 @@ static ssize_t hugetlb_cgroup_reset(struct kernfs_open_file *of,
>
> static char *mem_fmt(char *buf, int size, unsigned long hsize)
> {
> - if (hsize >= (1UL << 30))
> - snprintf(buf, size, "%luGB", hsize >> 30);
> - else if (hsize >= (1UL << 20))
> - snprintf(buf, size, "%luMB", hsize >> 20);
> + if (hsize >= SZ_1G)
> + snprintf(buf, size, "%luGB", hsize / SZ_1G);
> + else if (hsize >= SZ_1M)
> + snprintf(buf, size, "%luMB", hsize / SZ_1M);
> else
> - snprintf(buf, size, "%luKB", hsize >> 10);
> + snprintf(buf, size, "%luKB", hsize / SZ_1K);
> return buf;
> }
>
> --
> 2.23.0
>