2020-04-16 01:15:57

by Ralph Campbell

Subject: [PATCH] hugetlb_cgroup: remove unused variable 'i'

Compiling tests in tools/testing/selftests/vm/ results in a C compiler
warning:

write_to_hugetlbfs.c: In function ‘main’:
write_to_hugetlbfs.c:77:16: warning: unused variable ‘i’
77 | unsigned long i;

Delete the unused variable.

Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests")
Signed-off-by: Ralph Campbell <[email protected]>
---
tools/testing/selftests/vm/write_to_hugetlbfs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/vm/write_to_hugetlbfs.c b/tools/testing/selftests/vm/write_to_hugetlbfs.c
index 110bc4e4015d..6a2caba19ee1 100644
--- a/tools/testing/selftests/vm/write_to_hugetlbfs.c
+++ b/tools/testing/selftests/vm/write_to_hugetlbfs.c
@@ -74,8 +74,6 @@ int main(int argc, char **argv)
int write = 0;
int reserve = 1;

- unsigned long i;
-
if (signal(SIGINT, sig_handler) == SIG_ERR)
err(1, "\ncan't catch SIGINT\n");

--
2.25.2

2020-04-16 01:16:04

by Mina Almasry

Subject: Re: [PATCH] hugetlb_cgroup: remove unused variable 'i'

On Wed, Apr 15, 2020 at 5:26 PM Ralph Campbell <[email protected]> wrote:
>
> Compiling tests in tools/testing/selftests/vm/ results in a C compiler
> warning:
>
> write_to_hugetlbfs.c: In function ‘main’:
> write_to_hugetlbfs.c:77:16: warning: unused variable ‘i’
> 77 | unsigned long i;
>
> Delete the unused variable.
>
> Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests")
> Signed-off-by: Ralph Campbell <[email protected]>

Whoops, sorry about that.

Reviewed-by: Mina Almasry <[email protected]>

> ---
> tools/testing/selftests/vm/write_to_hugetlbfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/write_to_hugetlbfs.c b/tools/testing/selftests/vm/write_to_hugetlbfs.c
> index 110bc4e4015d..6a2caba19ee1 100644
> --- a/tools/testing/selftests/vm/write_to_hugetlbfs.c
> +++ b/tools/testing/selftests/vm/write_to_hugetlbfs.c
> @@ -74,8 +74,6 @@ int main(int argc, char **argv)
> int write = 0;
> int reserve = 1;
>
> - unsigned long i;
> -
> if (signal(SIGINT, sig_handler) == SIG_ERR)
> err(1, "\ncan't catch SIGINT\n");
>
> --
> 2.25.2
>