2021-08-06 14:53:48

by Michal Simek

Subject: [PATCH] arm64: zynqmp: Remove not documented is-dual property

Remove is-dual not documented property and also update comment about QSPI
sizes to reflect dual configuration as 16MB + 16MB.
Only single configuration is supported now.

Reported-by: Quanyang Wang <[email protected]>
Signed-off-by: Michal Simek <[email protected]>
---

arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 3 +--
arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 3 +--
arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index becfc23a5610..3d8d14ef1ede 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -937,9 +937,8 @@ &psgtr {

&qspi {
status = "okay";
- is-dual = <1>;
flash@0 {
- compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
+ compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
#address-cells = <1>;
#size-cells = <1>;
reg = <0x0>;
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
index d2219373580a..057c04352591 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
@@ -931,9 +931,8 @@ &psgtr {

&qspi {
status = "okay";
- is-dual = <1>;
flash@0 {
- compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
+ compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
#address-cells = <1>;
#size-cells = <1>;
reg = <0x0>;
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
index dac5ba67a160..e1fff62a4cd5 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
@@ -773,9 +773,8 @@ &psgtr {

&qspi {
status = "okay";
- is-dual = <1>;
flash@0 {
- compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
+ compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
#address-cells = <1>;
#size-cells = <1>;
reg = <0x0>;
--
2.32.0

2021-08-09 02:29:48

by Laurent Pinchart

Subject: Re: [PATCH] arm64: zynqmp: Remove not documented is-dual property

Hi Michal,

Thank you for the patch.

On Fri, Aug 06, 2021 at 10:42:29AM +0200, Michal Simek wrote:
> Remove is-dual not documented property and also update comment about QSPI
> sizes to reflect dual configuration as 16MB + 16MB.
> Only single configuration is supported now.
>
> Reported-by: Quanyang Wang <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 3 +--
> arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 3 +--
> arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 3 +--
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index becfc23a5610..3d8d14ef1ede 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -937,9 +937,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index d2219373580a..057c04352591 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -931,9 +931,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> index dac5ba67a160..e1fff62a4cd5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> @@ -773,9 +773,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;

--
Regards,

Laurent Pinchart

2021-08-25 06:23:03

by Michal Simek

Subject: Re: [PATCH] arm64: zynqmp: Remove not documented is-dual property

pá 6. 8. 2021 v 10:42 odesílatel Michal Simek <[email protected]> napsal:
>
> Remove is-dual not documented property and also update comment about QSPI
> sizes to reflect dual configuration as 16MB + 16MB.
> Only single configuration is supported now.
>
> Reported-by: Quanyang Wang <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 3 +--
> arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 3 +--
> arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 3 +--
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index becfc23a5610..3d8d14ef1ede 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -937,9 +937,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index d2219373580a..057c04352591 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -931,9 +931,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> index dac5ba67a160..e1fff62a4cd5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> @@ -773,9 +773,8 @@ &psgtr {
>
> &qspi {
> status = "okay";
> - is-dual = <1>;
> flash@0 {
> - compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> + compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x0>;
> --
> 2.32.0
>

Applied.
M

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs