2021-12-12 14:13:51

by Xiang wangx

Subject: [PATCH] microblaze: add const to of_device_id

struct of_device_id should normally be const.

Signed-off-by: Xiang wangx <[email protected]>
---
arch/microblaze/pci/xilinx_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/microblaze/pci/xilinx_pci.c b/arch/microblaze/pci/xilinx_pci.c
index b800909ddccf..f4cb86fffcee 100644
--- a/arch/microblaze/pci/xilinx_pci.c
+++ b/arch/microblaze/pci/xilinx_pci.c
@@ -27,7 +27,7 @@
#define PCI_HOST_ENABLE_CMD (PCI_COMMAND_SERR | PCI_COMMAND_PARITY | \
PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY)

-static struct of_device_id xilinx_pci_match[] = {
+static const struct of_device_id xilinx_pci_match[] = {
{ .compatible = "xlnx,plbv46-pci-1.03.a", },
{}
};
--
2.20.1

2021-12-13 15:27:45

by Michal Simek

Subject: Re: [PATCH] microblaze: add const to of_device_id

ne 12. 12. 2021 v 15:13 odesílatel Xiang wangx <[email protected]> napsal:
>
> struct of_device_id should normally be const.
>
> Signed-off-by: Xiang wangx <[email protected]>
> ---
> arch/microblaze/pci/xilinx_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/pci/xilinx_pci.c b/arch/microblaze/pci/xilinx_pci.c
> index b800909ddccf..f4cb86fffcee 100644
> --- a/arch/microblaze/pci/xilinx_pci.c
> +++ b/arch/microblaze/pci/xilinx_pci.c
> @@ -27,7 +27,7 @@
> #define PCI_HOST_ENABLE_CMD (PCI_COMMAND_SERR | PCI_COMMAND_PARITY | \
> PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY)
>
> -static struct of_device_id xilinx_pci_match[] = {
> +static const struct of_device_id xilinx_pci_match[] = {
> { .compatible = "xlnx,plbv46-pci-1.03.a", },
> {}
> };
> --
> 2.20.1
>

Applied.
M

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs