2021-10-14 10:16:56

by Michal Simek

Subject: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings

"xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
compatible strings were not moved to yaml format. But they were in origin
text file.

Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
Signed-off-by: Michal Simek <[email protected]>
---

Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
index 378da2649e66..980f92ad9eba 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
@@ -11,7 +11,11 @@ maintainers:

properties:
compatible:
- const: xlnx,zynq-gpio-1.0
+ enum:
+ - xlnx,zynq-gpio-1.0
+ - xlnx,zynqmp-gpio-1.0
+ - xlnx,versal-gpio-1.0
+ - xlnx,pmc-gpio-1.0

reg:
maxItems: 1
--
2.33.1

2021-10-14 15:52:30

by Rob Herring

Subject: Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings

On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote:
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1540859


gpio@ff0a0000: '#address-cells', 'gpio-line-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml

gpio@ff0a0000: '#address-cells', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml

2021-10-15 17:43:44

by Michal Simek

Subject: Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings

Hi Rob,

On 10/14/21 16:31, Rob Herring wrote:
> On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote:
>> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
>> compatible strings were not moved to yaml format. But they were in origin
>> text file.
>>
>> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
>> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1540859
>
>
> gpio@ff0a0000: '#address-cells', 'gpio-line-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml
>
> gpio@ff0a0000: '#address-cells', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml
>

I sent patches for listing power-domain and gpio-line-names based on
this patch.

Thanks,
Michal

2021-10-18 03:39:09

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings

On Thu, Oct 14, 2021 at 12:14 PM Michal Simek <[email protected]> wrote:

> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-10-27 10:57:33

by Rob Herring

Subject: Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings

On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote:
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>

2022-05-17 01:17:11

by Michal Simek

Subject: Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings

čt 14. 10. 2021 v 12:14 odesílatel Michal Simek
<[email protected]> napsal:
>
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> index 378da2649e66..980f92ad9eba 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> @@ -11,7 +11,11 @@ maintainers:
>
> properties:
> compatible:
> - const: xlnx,zynq-gpio-1.0
> + enum:
> + - xlnx,zynq-gpio-1.0
> + - xlnx,zynqmp-gpio-1.0
> + - xlnx,versal-gpio-1.0
> + - xlnx,pmc-gpio-1.0
>
> reg:
> maxItems: 1
> --
> 2.33.1
>

Applied.
M

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs