2021-10-15 17:43:44

by Michal Simek

[permalink] [raw]
Subject: [PATCH] dt-bindings: gpio: zynq: Describe gpio-line-names

Number of lines depends on compatible string from 58 to 174.
That's why it is checked based on it.

Signed-off-by: Michal Simek <[email protected]>
---

.../devicetree/bindings/gpio/gpio-zynq.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
index da95b951c23e..29c27eadbac8 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
@@ -28,6 +28,11 @@ properties:

gpio-controller: true

+ gpio-line-names:
+ description: strings describing the names of each gpio line
+ minItems: 58
+ maxItems: 174
+
interrupt-controller: true

"#interrupt-cells":
@@ -39,6 +44,51 @@ properties:
power-domains:
maxItems: 1

+allOf:
+ - if:
+ properties:
+ compatible:
+ enum:
+ - xlnx,zynqmp-gpio-1.0
+ then:
+ properties:
+ gpio-line-names:
+ minItems: 174
+ maxItems: 174
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - xlnx,zynq-gpio-1.0
+ then:
+ properties:
+ gpio-line-names:
+ minItems: 118
+ maxItems: 118
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - xlnx,versal-gpio-1.0
+ then:
+ properties:
+ gpio-line-names:
+ minItems: 58
+ maxItems: 58
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - xlnx,pmc-gpio-1.0
+ then:
+ properties:
+ gpio-line-names:
+ minItems: 116
+ maxItems: 116
+
required:
- compatible
- reg
--
2.33.1


2021-10-27 11:04:18

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: gpio: zynq: Describe gpio-line-names

On Fri, 15 Oct 2021 11:27:23 +0200, Michal Simek wrote:
> Number of lines depends on compatible string from 58 to 174.
> That's why it is checked based on it.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> .../devicetree/bindings/gpio/gpio-zynq.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2022-05-16 17:37:01

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: gpio: zynq: Describe gpio-line-names

pá 15. 10. 2021 v 11:27 odesílatel Michal Simek
<[email protected]> napsal:
>
> Number of lines depends on compatible string from 58 to 174.
> That's why it is checked based on it.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> .../devicetree/bindings/gpio/gpio-zynq.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> index da95b951c23e..29c27eadbac8 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> @@ -28,6 +28,11 @@ properties:
>
> gpio-controller: true
>
> + gpio-line-names:
> + description: strings describing the names of each gpio line
> + minItems: 58
> + maxItems: 174
> +
> interrupt-controller: true
>
> "#interrupt-cells":
> @@ -39,6 +44,51 @@ properties:
> power-domains:
> maxItems: 1
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - xlnx,zynqmp-gpio-1.0
> + then:
> + properties:
> + gpio-line-names:
> + minItems: 174
> + maxItems: 174
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - xlnx,zynq-gpio-1.0
> + then:
> + properties:
> + gpio-line-names:
> + minItems: 118
> + maxItems: 118
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - xlnx,versal-gpio-1.0
> + then:
> + properties:
> + gpio-line-names:
> + minItems: 58
> + maxItems: 58
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - xlnx,pmc-gpio-1.0
> + then:
> + properties:
> + gpio-line-names:
> + minItems: 116
> + maxItems: 116
> +
> required:
> - compatible
> - reg
> --
> 2.33.1
>

Applied.
M

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs