2020-11-20 18:37:01

by Gustavo A. R. Silva

Subject: [PATCH 061/141] tee: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/tee/tee_core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
index 6ade4a5c4840..5fdf26688230 100644
--- a/drivers/tee/tee_core.c
+++ b/drivers/tee/tee_core.c
@@ -452,6 +452,7 @@ static int params_to_user(struct tee_ioctl_param __user *uparams,
case TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_INOUT:
if (put_user((u64)p->u.memref.size, &up->b))
return -EFAULT;
+ break;
default:
break;
}
--
2.27.0

2020-11-22 09:28:43

by Jens Wiklander

Subject: Re: [PATCH 061/141] tee: Fix fall-through warnings for Clang

On Fri, Nov 20, 2020 at 7:33 PM Gustavo A. R. Silva
<[email protected]> wrote:
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/tee/tee_core.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Jens Wiklander <[email protected]>

Thanks,
Jens

2020-11-23 22:59:10

by Gustavo A. R. Silva

Subject: Re: [PATCH 061/141] tee: Fix fall-through warnings for Clang

On Sun, Nov 22, 2020 at 10:26:09AM +0100, Jens Wiklander wrote:
> On Fri, Nov 20, 2020 at 7:33 PM Gustavo A. R. Silva
> <[email protected]> wrote:
> >
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
> > ---
> > drivers/tee/tee_core.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Acked-by: Jens Wiklander <[email protected]>

Thanks, Jens.
--
Gustavo

2021-04-20 20:25:23

by Gustavo A. R. Silva

Subject: Re: [PATCH 061/141] tee: Fix fall-through warnings for Clang

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 11/23/20 16:55, Gustavo A. R. Silva wrote:
> On Sun, Nov 22, 2020 at 10:26:09AM +0100, Jens Wiklander wrote:
>> On Fri, Nov 20, 2020 at 7:33 PM Gustavo A. R. Silva
>> <[email protected]> wrote:
>>>
>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>>> by explicitly adding a break statement instead of letting the code fall
>>> through to the next case.
>>>
>>> Link: https://github.com/KSPP/linux/issues/115
>>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>>> ---
>>> drivers/tee/tee_core.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Acked-by: Jens Wiklander <[email protected]>
>
> Thanks, Jens.
> --
> Gustavo
>

2021-05-19 09:19:29

by Gustavo A. R. Silva

Subject: Re: [PATCH 061/141] tee: Fix fall-through warnings for Clang

Hi,

On 4/20/21 15:20, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 11/23/20 16:55, Gustavo A. R. Silva wrote:
>> On Sun, Nov 22, 2020 at 10:26:09AM +0100, Jens Wiklander wrote:
>>> On Fri, Nov 20, 2020 at 7:33 PM Gustavo A. R. Silva
>>> <[email protected]> wrote:
>>>>
>>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>>>> by explicitly adding a break statement instead of letting the code fall
>>>> through to the next case.
>>>>
>>>> Link: https://github.com/KSPP/linux/issues/115
>>>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>>>> ---
>>>> drivers/tee/tee_core.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>> Acked-by: Jens Wiklander <[email protected]>

I've added this to my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp