On Thu, Mar 03, 2022 at 04:31:30PM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <[email protected]>
>
> This patchset includes the following fixes:
>
> - Add dt-bindings description for NPCM845.
> - Bug fix for timeout calculation.
> - Better handling of spurious interrupts.
> - Fix for event type in slave mode.
> - Removal of own slave addresses [2:10].
> - Support for next gen BMC (NPCM845).
>
> The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
Overall my impression that the code was never tested for this driver and
somehow appears in the upstream and hence this series.
Anyway, I'm going to review the changes here.
--
With Best Regards,
Andy Shevchenko
On Thu, Mar 3, 2022 at 12:27 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Thu, Mar 03, 2022 at 04:31:30PM +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <[email protected]>
> >
> > This patchset includes the following fixes:
> >
> > - Add dt-bindings description for NPCM845.
> > - Bug fix for timeout calculation.
> > - Better handling of spurious interrupts.
> > - Fix for event type in slave mode.
> > - Removal of own slave addresses [2:10].
> > - Support for next gen BMC (NPCM845).
> >
> > The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
>
> Overall my impression that the code was never tested for this driver and
> somehow appears in the upstream and hence this series.
>
> Anyway, I'm going to review the changes here.
>
> --
Actually it was and is being used by multiple users in lots of BMCs.
We haven't submitted patches for this driver for a while
and accumulated them all on Nuvoton Github repo, but now we wanted to
clear the table.
All your comments will be addressed and fixed for the next patchset.
As always, we really appreciate your review and taking the time to go
through all these changes.
> With Best Regards,
> Andy Shevchenko
>
>
Thanks!
Tali Perry