2014-02-19 05:09:57

by Daeseok Youn

Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with kstrtouint()

>From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
kstrtouint()

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/ata/libahci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 36605ab..417946b 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1032,12 +1032,13 @@ static ssize_t ahci_led_show(struct ata_port *ap, char
*buf)
static ssize_t ahci_led_store(struct ata_port *ap, const char *buf,
size_t size)
{
- int state;
+ unsigned int state;
int pmp;
struct ahci_port_priv *pp = ap->private_data;
struct ahci_em_priv *emp;

- state = simple_strtoul(buf, NULL, 0);
+ if (kstrtouint(buf, 0, &state) < 0)
+ return -EINVAL;

/* get the slot number from the message */
pmp = (state & EM_MSG_LED_PMP_SLOT) >> 8;
--
1.7.9.5
---

2014-02-19 06:05:12

by David Miller

Subject: Re: [PATCH] atm: libahci: replace obselete simple_strtoul() with kstrtouint()

From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 14:09:49 +0900

> From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 13:44:24 +0900
> Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
> kstrtouint()
>
> Signed-off-by: Daeseok Youn <[email protected]>

Please fix your Subject line, you meant "ata: " not "atm: "

2014-02-19 06:19:57

by Daeseok Youn

Subject: Re: [PATCH] atm: libahci: replace obselete simple_strtoul() with kstrtouint()

I re-send this patch after fixing subject.
Thanks.

Daeseok Youn

2014-02-19 15:05 GMT+09:00 David Miller <[email protected]>:
> From: Daeseok Youn <[email protected]>
> Date: Wed, 19 Feb 2014 14:09:49 +0900
>
>> From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <[email protected]>
>> Date: Wed, 19 Feb 2014 13:44:24 +0900
>> Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
>> kstrtouint()
>>
>> Signed-off-by: Daeseok Youn <[email protected]>
>
> Please fix your Subject line, you meant "ata: " not "atm: "

2014-02-19 12:40:47

by Sergei Shtylyov

Subject: Re: [PATCH] atm: libahci: replace obselete simple_strtoul() with kstrtouint()

Hello.

On 19-02-2014 10:05, David Miller wrote:

>> From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <[email protected]>
>> Date: Wed, 19 Feb 2014 13:44:24 +0900
>> Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
>> kstrtouint()

>> Signed-off-by: Daeseok Youn <[email protected]>

> Please fix your Subject line, you meant "ata: " not "atm: "

And "obsolete". :-)

WBR, Sergei