>From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Mon, 24 Feb 2014 09:17:41 +0900
Subject: [PATCH] staging: ced401: remove redundant spin_unlock
sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/staging/ced1401/usb1401.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c
index efc310c..8195eb9 100644
--- a/drivers/staging/ced1401/usb1401.c
+++ b/drivers/staging/ced1401/usb1401.c
@@ -1053,7 +1053,6 @@ static int Handle1401Esc(DEVICE_EXTENSION *pdx, char *pCh,
/* This can never happen, really */
dev_err(&pdx->interface->dev,
"ERROR: DMA setup while transfer still waiting");
- spin_unlock(&pdx->stagedLock);
} else {
if ((wTransType == TM_EXTTOHOST)
|| (wTransType == TM_EXTTO1401)) {
--
1.7.9.5
---
On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Mon, 24 Feb 2014 09:17:41 +0900
> Subject: [PATCH] staging: ced401: remove redundant spin_unlock
Don't send this header. We get everything from the email header.
>
> sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
> context imbalance in 'Handle1401Esc' - unexpected unlock
>
Your fix is correct, but the changelog is not good. These messages in
Sparse are wrong over 80% of the time. So when I see one in a commit
message I assume it is wrong. Add some more explanation to say why you
removed the spin_unlock.
Also "redundant" means "unnecessary" but sort of implies that it is
harmless. Say something like: "staging: ced401: fix double unlock bug".
regards,
dan carpenter
2014-02-24 17:06 GMT+09:00 Dan Carpenter <[email protected]>:
> On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
>> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <[email protected]>
>> Date: Mon, 24 Feb 2014 09:17:41 +0900
>> Subject: [PATCH] staging: ced401: remove redundant spin_unlock
>
> Don't send this header. We get everything from the email header.
Actually, I did attach a file which is output of "git format-patch"
with text mode. So this header was included in my e-mail.
I will remove this header and send patch again. And I don't send this
header again.
>
>>
>> sparse says:
>> drivers/staging/ced1401/usb1401.c:1080:28: warning:
>> context imbalance in 'Handle1401Esc' - unexpected unlock
>>
>
> Your fix is correct, but the changelog is not good. These messages in
> Sparse are wrong over 80% of the time. So when I see one in a commit
> message I assume it is wrong. Add some more explanation to say why you
> removed the spin_unlock.
You're right. I will add more explanation about this patch.
>
> Also "redundant" means "unnecessary" but sort of implies that it is
> harmless. Say something like: "staging: ced401: fix double unlock bug".
Ok. fix my subject as your comment.
>
> regards,
> dan carpenter
>
Thanks for your comment.