2022-11-08 19:33:59

by Andrew Morton

[permalink] [raw]
Subject: Re: [mm-unstable v3 PATCH 2/3] mm: khugepaged: allow page allocation fallback to eligible nodes

On Tue, 8 Nov 2022 10:43:56 -0800 Yang Shi <[email protected]> wrote:

> Syzbot reported the below splat:
>
> ...
>

"mm: don't warn if the node is offlined" remains in
mm-hotfixes-unstable, so I'll just drop it.

>
> Reported-by: [email protected]
> Suggested-by: Zach O'Keefe <[email protected]>
> Suggested-by: Michal Hocko <[email protected]>
> Reviewed-by: Zach O'Keefe <[email protected]>
> Acked-by: Michal Hocko <[email protected]>
> Signed-off-by: Yang Shi <[email protected]>

I should add cc:stable, yes?

Are we able to identify a Fixes: target?




2022-11-08 20:20:56

by Yang Shi

[permalink] [raw]
Subject: Re: [mm-unstable v3 PATCH 2/3] mm: khugepaged: allow page allocation fallback to eligible nodes

On Tue, Nov 8, 2022 at 11:20 AM Andrew Morton <[email protected]> wrote:
>
> On Tue, 8 Nov 2022 10:43:56 -0800 Yang Shi <[email protected]> wrote:
>
> > Syzbot reported the below splat:
> >
> > ...
> >
>
> "mm: don't warn if the node is offlined" remains in
> mm-hotfixes-unstable, so I'll just drop it.

Yes, please.

>
> >
> > Reported-by: [email protected]
> > Suggested-by: Zach O'Keefe <[email protected]>
> > Suggested-by: Michal Hocko <[email protected]>
> > Reviewed-by: Zach O'Keefe <[email protected]>
> > Acked-by: Michal Hocko <[email protected]>
> > Signed-off-by: Yang Shi <[email protected]>
>
> I should add cc:stable, yes?

This problem should just happen with MADV_COLLAPSE, which is merged
for 6.1, so we should not cc to stable.

>
> Are we able to identify a Fixes: target?

Please use this target: 7d8faaf15545 mm/madvise: introduce
MADV_COLLAPSE sync hugepage collapse

>
>